Commit691ac9d

authored and

committed

Backport PR#21131: Fix polar() regression on second call failure

1 parent79a38ec commit691ac9dCopy full SHA for 691ac9d

File tree

+14

-6

lines changed

+14

-6

lines changed

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2478,14 +2478,12 @@ def polar(args, *kwargs):`
`2478`	`2478`	`# If an axis already exists, check if it has a polar projection`
`2479`	`2479`	`ifgcf().get_axes():`
`2480`	`2480`	`ax=gca()`
`2481`		`-ifisinstance(ax,PolarAxes):`
`2482`		`-returnax`
`2483`		`-else:`
	`2481`	`+ifnotisinstance(ax,PolarAxes):`
`2484`	`2482`	`_api.warn_external('Trying to create polar plot on an Axes '`
`2485`	`2483`	`'that does not have a polar projection.')`
`2486`		`-ax=axes(projection="polar")`
`2487`		`-ret=ax.plot(args,*kwargs)`
`2488`		`-returnret`
	`2484`	`+else:`
	`2485`	`+ax=axes(projection="polar")`
	`2486`	`+returnax.plot(args,*kwargs)`
`2489`	`2487`
`2490`	`2488`
`2491`	`2489`	`# If rcParams['backend_fallback'] is true, and an interactive backend is`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -310,3 +310,13 @@ def test_subplot_change_projection():`
`310`	`310`	`assertax_next.name==proj`
`311`	`311`	`assertaxisnotax_next`
`312`	`312`	`ax=ax_next`
	`313`	`+`
	`314`	`+`
	`315`	`+deftest_polar_second_call():`
	`316`	`+# the first call creates the axes with polar projection`
	`317`	`+ln1,=plt.polar(0.,1.,'ro')`
	`318`	`+assertisinstance(ln1,mpl.lines.Line2D)`
	`319`	`+# the second call should reuse the existing axes`
	`320`	`+ln2,=plt.polar(1.57,.5,'bo')`
	`321`	`+assertisinstance(ln2,mpl.lines.Line2D)`
	`322`	`+assertln1.axesisln2.axes`

Comments

(0)