NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Commit662642c

committed

FIX: Disable cursorRect updates from within macosx backend

We want to keep control of the cursor updates from within MPL, sodon't allow the App to push a new cursor update when the windowgets updated. This would happen when a TextView would get resizedand update the frame.

1 parentf732864 commit662642cCopy full SHA for 662642c

File tree

1 file changed

-3

lines changed

src
- _macosx.m

1 file changed

-3

lines changed

`‎src/_macosx.m‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -588,6 +588,10 @@ static CGFloat _get_device_scale(CGContextRef cr)`
`588`	`588`	`Window* window = self->window;`
`589`	`589`	`[windowsetDelegate: view];`
`590`	`590`	`[windowmakeFirstResponder: view];`
	`591`	`+// Disable cursorRects so that the cursor doesn't get updated by events`
	`592`	`+// in NSApp (like resizing TextViews), we want to handle the cursor`
	`593`	`+// changes from within MPL with set_cursor() ourselves`
	`594`	`+ [windowdisableCursorRects];`
`591`	`595`	`[[windowcontentView]addSubview: view];`
`592`	`596`	`[viewupdateDevicePixelRatio: [windowbackingScaleFactor]];`
`593`	`597`
`@@ -989,9 +993,6 @@ -(void)save_figure:(id)sender { gil_call_method(toolbar, "save_figure"); }`
`989`	`993`	`[messageboxsetFrame: rect];`
`990`	`994`	`// We want to control the vertical position of`
`991`	`995`	`// the rect by the content size to center it vertically`
`992`		`-// TODO: This seems to disable the cursor updates with newlines that`
`993`		`-// are included in the image hover text. It is only when trying`
`994`		`-// to set the frame height based on the contentRect's size.`
`995`	`996`	`[messagebox.layoutManagerensureLayoutForTextContainer: messagebox.textContainer];`
`996`	`997`	`NSRect contentRect = [messagebox.layoutManagerusedRectForTextContainer: messagebox.textContainer];`
`997`	`998`	`rect.origin.y =0.5 * (self->height - contentRect.size.height);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit662642c

File tree

1 file changed

1 file changed

`‎src/_macosx.m‎`

0 commit comments