Commit641d2fa

authored

Merge pull request#18505 from QuLogic/empty-depthshading

Fix depth shading when edge/facecolor is none.

2 parentsa4128a7 +22627ca commit641d2faCopy full SHA for 641d2fa

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -809,7 +809,7 @@ def _zalpha(colors, zs):`
`809`	`809`	`# in all three dimensions. Otherwise, at certain orientations,`
`810`	`810`	`# the min and max zs are very close together.`
`811`	`811`	`# Should really normalize against the viewing depth.`
`812`		`-iflen(zs)==0:`
	`812`	`+iflen(colors)==0orlen(zs)==0:`
`813`	`813`	`returnnp.zeros((0,4))`
`814`	`814`	`norm=Normalize(min(zs),max(zs))`
`815`	`815`	`sats=1-norm(zs)*0.7`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,14 @@ def test_scatter3d():`
`237`	`237`	`deftest_scatter3d_color():`
`238`	`238`	`fig=plt.figure()`
`239`	`239`	`ax=fig.add_subplot(111,projection='3d')`
	`240`	`+`
	`241`	`+# Check that 'none' color works; these two should overlay to produce the`
	`242`	+# same as setting just `color`.
	`243`	`+ax.scatter(np.arange(10),np.arange(10),np.arange(10),`
	`244`	`+facecolor='r',edgecolor='none',marker='o')`
`240`	`245`	`ax.scatter(np.arange(10),np.arange(10),np.arange(10),`
`241`		`-color='r',marker='o')`
	`246`	`+facecolor='none',edgecolor='r',marker='o')`
	`247`	`+`
`242`	`248`	`ax.scatter(np.arange(10,20),np.arange(10,20),np.arange(10,20),`
`243`	`249`	`color='b',marker='s')`
`244`	`250`

Comments

(0)