Commit560ccff

authored

Merge pull request#18091 from QuLogic/flake8

ci: Fix linting being ignored by reviewdog

2 parentsfecfa1a +3eb4779 commit560ccffCopy full SHA for 560ccff

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ jobs:`
`29`	`29`	`REVIEWDOG_GITHUB_API_TOKEN:${{ secrets.GITHUB_TOKEN }}`
`30`	`30`	`run:\|`
`31`	`31`	`flake8 --docstring-convention=all \| \`
`32`		`- reviewdog -f=pep8 -name=flake8 -reporter=github-check`
	`32`	`+ reviewdog -f=pep8 -name=flake8 \`
	`33`	`+ -tee -reporter=github-check -filter-mode nofilter`
`33`	`34`
`34`	`35`	`eslint:`
`35`	`36`	`name:eslint`
`@@ -40,6 +41,7 @@ jobs:`
`40`	`41`	`-name:eslint`
`41`	`42`	`uses:reviewdog/action-eslint@v1`
`42`	`43`	`with:`
	`44`	`+filter_mode:nofilter`
`43`	`45`	`github_token:${{ secrets.GITHUB_TOKEN }}`
`44`	`46`	`reporter:github-check`
`45`	`47`	`workdir:'lib/matplotlib/backends/web_backend/'`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -830,8 +830,8 @@ def axhline(self, y=0, xmin=0, xmax=1, **kwargs):`
`830`	`830`	`"""`
`831`	`831`	`self._check_no_units([xmin,xmax], ['xmin','xmax'])`
`832`	`832`	`if"transform"inkwargs:`
`833`		`-raiseValueError("'transform' is not allowed as a keywordargument;"`
`834`		`-"axhline generates its own transform.")`
	`833`	`+raiseValueError("'transform' is not allowed as a keyword "`
	`834`	`+"argument;axhline generates its own transform.")`
`835`	`835`	`ymin,ymax=self.get_ybound()`
`836`	`836`
`837`	`837`	`# We need to strip away the units for comparison with`
`@@ -899,8 +899,8 @@ def axvline(self, x=0, ymin=0, ymax=1, **kwargs):`
`899`	`899`	`"""`
`900`	`900`	`self._check_no_units([ymin,ymax], ['ymin','ymax'])`
`901`	`901`	`if"transform"inkwargs:`
`902`		`-raiseValueError("'transform' is not allowed as a keywordargument;"`
`903`		`-"axvline generates its own transform.")`
	`902`	`+raiseValueError("'transform' is not allowed as a keyword "`
	`903`	`+"argument;axvline generates its own transform.")`
`904`	`904`	`xmin,xmax=self.get_xbound()`
`905`	`905`
`906`	`906`	`# We need to strip away the units for comparison with`

Lines changed: 0 additions & 1 deletion

Comments

(0)