Commit4aa7efe

authored

Merge pull request#27004 from borgesaugusto/iss_24050

Warning if handles and labels have a len mismatch

2 parents7f63a18 +38a17d6 commit4aa7efeCopy full SHA for 4aa7efe

File tree

+24

-0

lines changed

+24

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1337,6 +1337,12 @@ def _parse_legend_args(axs, args, handles=None, labels=None, *kwargs):`
`1337`	`1337`	`_api.warn_external("You have mixed positional and keyword arguments, "`
`1338`	`1338`	`"some input may be discarded.")`
`1339`	`1339`
	`1340`	`+if (hasattr(handles,"__len__")and`
	`1341`	`+hasattr(labels,"__len__")and`
	`1342`	`+len(handles)!=len(labels)):`
	`1343`	`+_api.warn_external(f"Mismatched number of handles and labels: "`
	`1344`	`+f"len(handles) ={len(handles)} "`
	`1345`	`+f"len(labels) ={len(labels)}")`
`1340`	`1346`	`# if got both handles and labels as kwargs, make same length`
`1341`	`1347`	`ifhandlesandlabels:`
`1342`	`1348`	`handles,labels=zip(*zip(handles,labels))`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1357,3 +1357,21 @@ def test_loc_validation_string_value():`
`1357`	`1357`	`ax.legend(loc='upper center')`
`1358`	`1358`	`withpytest.raises(ValueError,match="'wrong' is not a valid value for"):`
`1359`	`1359`	`ax.legend(loc='wrong')`
	`1360`	`+`
	`1361`	`+`
	`1362`	`+deftest_legend_handle_label_mismatch():`
	`1363`	`+pl1,=plt.plot(range(10))`
	`1364`	`+pl2,=plt.plot(range(10))`
	`1365`	`+withpytest.warns(UserWarning,match="number of handles and labels"):`
	`1366`	`+legend=plt.legend(handles=[pl1,pl2],labels=["pl1","pl2","pl3"])`
	`1367`	`+assertlen(legend.legend_handles)==2`
	`1368`	`+assertlen(legend.get_texts())==2`
	`1369`	`+`
	`1370`	`+`
	`1371`	`+deftest_legend_handle_label_mismatch_no_len():`
	`1372`	`+pl1,=plt.plot(range(10))`
	`1373`	`+pl2,=plt.plot(range(10))`
	`1374`	`+legend=plt.legend(handles=iter([pl1,pl2]),`
	`1375`	`+labels=iter(["pl1","pl2","pl3"]))`
	`1376`	`+assertlen(legend.legend_handles)==2`
	`1377`	`+assertlen(legend.get_texts())==2`

Comments

(0)