NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Commit37e5518

committed

TST: Fix tight layout tests without text

If we pass `remove_text` to `image_comparison`, we don't expect tests tochange from FreeType. But if `tight_layout` is called *before* the endof the test function, the layout will happen with the text that wassupposed to be removed.

1 parent60c293f commit37e5518Copy full SHA for 37e5518

File tree

4 files changed

-7

lines changed

lib
- matplotlib/tests
  - baseline_images/test_table
    - table_cell_manipulation.png
  - test_table.py
- mpl_toolkits/axisartist/tests
  - baseline_images/test_axislines
    - axisline_style_tight.png
  - test_axislines.py

4 files changed

-7

lines changed

`‎lib/matplotlib/tests/baseline_images/test_table/table_cell_manipulation.png`

-2.26 KB

`‎lib/matplotlib/tests/test_table.py`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,13 +87,13 @@ def test_label_colours():`
`87`	`87`	`loc='best')`
`88`	`88`
`89`	`89`
`90`		`-@image_comparison(['table_cell_manipulation.png'],remove_text=True)`
`91`		`-deftest_diff_cell_table():`
	`90`	`+@image_comparison(['table_cell_manipulation.png'])`
	`91`	`+deftest_diff_cell_table(_text_placeholders):`
`92`	`92`	`cells= ('horizontal','vertical','open','closed','T','R','B','L')`
`93`	`93`	`cellText= [['1']len(cells)]2`
`94`	`94`	`colWidths= [0.1]*len(cells)`
`95`	`95`
`96`		`-_,axs=plt.subplots(nrows=len(cells),figsize=(4,len(cells)+1))`
	`96`	`+_,axs=plt.subplots(nrows=len(cells),figsize=(4,len(cells)+1),layout='tight')`
`97`	`97`	`forax,cellinzip(axs,cells):`
`98`	`98`	`ax.table(`
`99`	`99`	`colWidths=colWidths,`
`@@ -102,7 +102,6 @@ def test_diff_cell_table():`
`102`	`102`	`edges=cell,`
`103`	`103`	`)`
`104`	`104`	`ax.axis('off')`
`105`		`-plt.tight_layout()`
`106`	`105`
`107`	`106`
`108`	`107`	`deftest_customcell():`

`‎lib/mpl_toolkits/axisartist/tests/baseline_images/test_axislines/axisline_style_tight.png`

2 Bytes

`‎lib/mpl_toolkits/axisartist/tests/test_axislines.py`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ def test_axisline_style_size_color():`
`119`	`119`	`@image_comparison(['axisline_style_tight.png'],remove_text=True,`
`120`	`120`	`style='mpl20')`
`121`	`121`	`deftest_axisline_style_tight():`
`122`		`-fig=plt.figure(figsize=(2,2))`
	`122`	`+fig=plt.figure(figsize=(2,2),layout='tight')`
`123`	`123`	`ax=fig.add_subplot(axes_class=AxesZero)`
`124`	`124`	`ax.axis["xzero"].set_axisline_style("-\|>",size=5,facecolor='g')`
`125`	`125`	`ax.axis["xzero"].set_visible(True)`
`@@ -129,8 +129,6 @@ def test_axisline_style_tight():`
`129`	`129`	`fordirectionin ("left","right","bottom","top"):`
`130`	`130`	`ax.axis[direction].set_visible(False)`
`131`	`131`
`132`		`-fig.tight_layout()`
`133`		`-`
`134`	`132`
`135`	`133`	`@image_comparison(['subplotzero_ylabel.png'],style='mpl20')`
`136`	`134`	`deftest_subplotzero_ylabel():`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit37e5518

File tree

4 files changed

4 files changed

`‎lib/matplotlib/tests/baseline_images/test_table/table_cell_manipulation.png`

`‎lib/matplotlib/tests/test_table.py`

`‎lib/mpl_toolkits/axisartist/tests/baseline_images/test_axislines/axisline_style_tight.png`

`‎lib/mpl_toolkits/axisartist/tests/test_axislines.py`

0 commit comments