Commit24e3013

authored

Merge pull request#28479 from rcomer/v3.9.x

Backport PR#28397 (FIX: stale root Figure when adding/updating subfigures)

2 parents826575f +bbb0d01 commit24e3013Copy full SHA for 24e3013

File tree

+26

-0

lines changed

+26

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1633,6 +1633,8 @@ def add_subfigure(self, subplotspec, **kwargs):`
`1633`	`1633`	`sf=SubFigure(self,subplotspec,**kwargs)`
`1634`	`1634`	`self.subfigs+= [sf]`
`1635`	`1635`	`sf._remove_method=self.subfigs.remove`
	`1636`	`+sf.stale_callback=_stale_figure_callback`
	`1637`	`+self.stale=True`
`1636`	`1638`	`returnsf`
`1637`	`1639`
`1638`	`1640`	`defsca(self,a):`

Lines changed: 24 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1733,3 +1733,27 @@ def test_warn_colorbar_mismatch():`
`1733`	`1733`	`subfig3_1.colorbar(im3_2)# should not warn`
`1734`	`1734`	`withpytest.warns(UserWarning,match="different Figure"):`
`1735`	`1735`	`subfig3_1.colorbar(im4_1)`
	`1736`	`+`
	`1737`	`+`
	`1738`	`+deftest_subfigure_stale_propagation():`
	`1739`	`+fig=plt.figure()`
	`1740`	`+`
	`1741`	`+fig.draw_without_rendering()`
	`1742`	`+assertnotfig.stale`
	`1743`	`+`
	`1744`	`+sfig1=fig.subfigures()`
	`1745`	`+assertfig.stale`
	`1746`	`+`
	`1747`	`+fig.draw_without_rendering()`
	`1748`	`+assertnotfig.stale`
	`1749`	`+assertnotsfig1.stale`
	`1750`	`+`
	`1751`	`+sfig2=sfig1.subfigures()`
	`1752`	`+assertfig.stale`
	`1753`	`+`
	`1754`	`+fig.draw_without_rendering()`
	`1755`	`+assertnotfig.stale`
	`1756`	`+assertnotsfig2.stale`
	`1757`	`+`
	`1758`	`+sfig2.stale=True`
	`1759`	`+assertfig.stale`

Comments

(0)