Commit1e4823b

committed

Merge pull request#5387 from jenshnielsen/pipmptesting

Fix#3314 assert mods.pop(0) fails

1 parentfeaf9c6 commit1e4823bCopy full SHA for 1e4823b

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -328,8 +328,13 @@ def _image_directories(func):`
`328`	`328`	`subdir=os.path.splitext(os.path.split(script_name)[1])[0]`
`329`	`329`	`else:`
`330`	`330`	`mods=module_name.split('.')`
`331`		`-mods.pop(0)# <- will be the name of the package being tested (in`
`332`		`-# most cases "matplotlib")`
	`331`	`+iflen(mods)>=3:`
	`332`	`+mods.pop(0)`
	`333`	`+# mods[0] will be the name of the package being tested (in`
	`334`	`+# most cases "matplotlib") However if this is a`
	`335`	`+# namespace package pip installed and run via the nose`
	`336`	`+# multiprocess plugin or as a specific test this may be`
	`337`	`+# missing. See https://github.com/matplotlib/matplotlib/issues/3314`
`333`	`338`	`assertmods.pop(0)=='tests'`
`334`	`339`	`subdir=os.path.join(*mods)`
`335`	`340`

Comments

(0)