NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Commit0d0bde4

committed

Remove unnecessary explicit default loc='best' in legend()

1 parentc6ce3f6 commit0d0bde4Copy full SHA for 0d0bde4

File tree

4 files changed

+14

-14

lines changed

examples
- api
  - sankey_basics.py
- recipes
  - transparent_legends.py
lib/matplotlib
- pyplot.py
- tests
  - test_legend.py

4 files changed

+14

-14

lines changed

`‎examples/api/sankey_basics.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@`
`91`	`91`	`orientations=[-1,-1,-1],prior=0,connect=(0,0))`
`92`	`92`	`diagrams=sankey.finish()`
`93`	`93`	`diagrams[-1].patch.set_hatch('/')`
`94`		`-plt.legend(loc='best')`
	`94`	`+plt.legend()`
`95`	`95`
`96`	`96`	`###############################################################################`
`97`	`97`	`# Notice that only one connection is specified, but the systems form a`

`‎examples/recipes/transparent_legends.py`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,10 @@`
`9`	`9`
`10`	`10`	`ax.legend(loc='upper right')`
`11`	`11`
`12`		`-Other times you don't know where your data is, and loc='best' will try`
`13`		`-and place the legend::`
	`12`	`+Other times you don't know where your data is, andthe defaultloc='best'`
	`13`	`+will tryand place the legend::`
`14`	`14`
`15`		`- ax.legend(loc='best')`
	`15`	`+ ax.legend()`
`16`	`16`
`17`	`17`	`but still, your legend may overlap your data, and in these cases it's`
`18`	`18`	`nice to make the legend frame transparent.`
`@@ -27,7 +27,7 @@`
`27`	`27`	`ax.plot(np.random.rand(300),'s-',label='uniform distribution')`
`28`	`28`	`ax.set_ylim(-3,3)`
`29`	`29`
`30`		`-ax.legend(loc='best',fancybox=True,framealpha=0.5)`
	`30`	`+ax.legend(fancybox=True,framealpha=0.5)`
`31`	`31`	`ax.set_title('fancy, transparent legends')`
`32`	`32`
`33`	`33`	`plt.show()`

`‎lib/matplotlib/pyplot.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2192,7 +2192,7 @@ def getname_val(identifier):`
`2192`	`2192`	`ax.set_xlabel('')`
`2193`	`2193`
`2194`	`2194`	`ifnotsubplots:`
`2195`		`-ax.legend(ynamelist,loc='best')`
	`2195`	`+ax.legend(ynamelist)`
`2196`	`2196`
`2197`	`2197`	`ifxname=='date':`
`2198`	`2198`	`fig.autofmt_xdate()`

`‎lib/matplotlib/tests/test_legend.py`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ def test_legend_auto1():`
`40`	`40`	`x=np.arange(100)`
`41`	`41`	`ax.plot(x,50-x,'o',label='y=1')`
`42`	`42`	`ax.plot(x,x-50,'o',label='y=-1')`
`43`		`-ax.legend(loc='best')`
	`43`	`+ax.legend()`
`44`	`44`
`45`	`45`
`46`	`46`	`@image_comparison(baseline_images=['legend_auto2'],remove_text=True)`
`@@ -51,7 +51,7 @@ def test_legend_auto2():`
`51`	`51`	`x=np.arange(100)`
`52`	`52`	`b1=ax.bar(x,x,align='edge',color='m')`
`53`	`53`	`b2=ax.bar(x,x[::-1],align='edge',color='g')`
`54`		`-ax.legend([b1[0],b2[0]], ['up','down'],loc='best')`
	`54`	`+ax.legend([b1[0],b2[0]], ['up','down'])`
`55`	`55`
`56`	`56`
`57`	`57`	`@image_comparison(baseline_images=['legend_auto3'])`
`@@ -64,7 +64,7 @@ def test_legend_auto3():`
`64`	`64`	`ax.plot(x,y,'o-',label='line')`
`65`	`65`	`ax.set_xlim(0.0,1.0)`
`66`	`66`	`ax.set_ylim(0.0,1.0)`
`67`		`-ax.legend(loc='best')`
	`67`	`+ax.legend()`
`68`	`68`
`69`	`69`
`70`	`70`	`@image_comparison(baseline_images=['legend_various_labels'],remove_text=True)`
`@@ -75,7 +75,7 @@ def test_various_labels():`
`75`	`75`	`ax.plot(np.arange(4),'o',label=1)`
`76`	`76`	`ax.plot(np.linspace(4,4.1),'o',label='Développés')`
`77`	`77`	`ax.plot(np.arange(4,1,-1),'o',label='__nolegend__')`
`78`		`-ax.legend(numpoints=1,loc='best')`
	`78`	`+ax.legend(numpoints=1)`
`79`	`79`
`80`	`80`
`81`	`81`	`@image_comparison(baseline_images=['legend_labels_first'],extensions=['png'],`
`@@ -87,7 +87,7 @@ def test_labels_first():`
`87`	`87`	`ax.plot(np.arange(10),'-o',label=1)`
`88`	`88`	`ax.plot(np.ones(10)*5,':x',label="x")`
`89`	`89`	`ax.plot(np.arange(20,10,-1),'d',label="diamond")`
`90`		`-ax.legend(loc='best',markerfirst=False)`
	`90`	`+ax.legend(markerfirst=False)`
`91`	`91`
`92`	`92`
`93`	`93`	`@image_comparison(baseline_images=['legend_multiple_keys'],extensions=['png'],`
`@@ -371,7 +371,7 @@ def test_legend_stackplot():`
`371`	`371`	`ax.stackplot(x,y1,y2,y3,labels=['y1','y2','y3'])`
`372`	`372`	`ax.set_xlim((0,10))`
`373`	`373`	`ax.set_ylim((0,70))`
`374`		`-ax.legend(loc='best')`
	`374`	`+ax.legend()`
`375`	`375`
`376`	`376`
`377`	`377`	`deftest_cross_figure_patch_legend():`
`@@ -424,7 +424,7 @@ def test_not_covering_scatter():`
`424`	`424`	`forninrange(3):`
`425`	`425`	`plt.scatter([n], [n],color=colors[n])`
`426`	`426`
`427`		`-plt.legend(['foo','foo','foo'],loc='best')`
	`427`	`+plt.legend(['foo','foo','foo'])`
`428`	`428`	`plt.gca().set_xlim(-0.5,2.2)`
`429`	`429`	`plt.gca().set_ylim(-0.5,2.2)`
`430`	`430`
`@@ -439,7 +439,7 @@ def test_not_covering_scatter_transform():`
`439`	`439`
`440`	`440`	`plt.scatter([20], [10],transform=offset+plt.gca().transData)`
`441`	`441`
`442`		`-plt.legend(['foo','bar'],loc='best')`
	`442`	`+plt.legend(['foo','bar'])`
`443`	`443`
`444`	`444`
`445`	`445`	`deftest_linecollection_scaled_dashes():`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit0d0bde4

File tree

4 files changed

4 files changed

`‎examples/api/sankey_basics.py`

`‎examples/recipes/transparent_legends.py`

`‎lib/matplotlib/pyplot.py`

`‎lib/matplotlib/tests/test_legend.py`

0 commit comments