Commit07f34aa

committed

Avoid modifying user input to Axes.bar

The `error_kw` parameter is a dictionary, on which `setdefault` and`pop` are called, which would modify user input.

1 parent787f308 commit07f34aaCopy full SHA for 07f34aa

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2434,7 +2434,8 @@ def bar(self, x, height, width=0.8, bottom=None, *, align="center",`
`2434`	`2434`	`# checking and processing will be left to the errorbar method.`
`2435`	`2435`	`xerr=kwargs.pop('xerr',None)`
`2436`	`2436`	`yerr=kwargs.pop('yerr',None)`
`2437`		`-error_kw=kwargs.pop('error_kw', {})`
	`2437`	`+error_kw=kwargs.pop('error_kw',None)`
	`2438`	`+error_kw= {}iferror_kwisNoneelseerror_kw.copy()`
`2438`	`2439`	`ezorder=error_kw.pop('zorder',None)`
`2439`	`2440`	`ifezorderisNone:`
`2440`	`2441`	`ezorder=kwargs.get('zorder',None)`
`@@ -2590,9 +2591,8 @@ def bar(self, x, height, width=0.8, bottom=None, *, align="center",`
`2590`	`2591`
`2591`	`2592`	`error_kw.setdefault("label",'_nolegend_')`
`2592`	`2593`
`2593`		`-errorbar=self.errorbar(ex,ey,`
`2594`		`-yerr=yerr,xerr=xerr,`
`2595`		`-fmt='none',**error_kw)`
	`2594`	`+errorbar=self.errorbar(ex,ey,yerr=yerr,xerr=xerr,fmt='none',`
	`2595`	`+**error_kw)`
`2596`	`2596`	`else:`
`2597`	`2597`	`errorbar=None`
`2598`	`2598`

Comments

(0)