Commit060fa00

committed

BUG: raise when creating a MacOS FigureManager outside the main thread

1 parente0f0ded commit060fa00Copy full SHA for 060fa00

File tree

+26

-0

lines changed

+26

-0

lines changed

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`importos`
	`2`	`+importthreading`
`2`	`3`	`frompathlibimportPath`
`3`	`4`
`4`	`5`	`importpytest`
`@@ -84,3 +85,18 @@ def _test_save_figure_return():`
`84`	`85`	`deftest_save_figure_return():`
`85`	`86`	`subprocess_run_helper(_test_save_figure_return,timeout=_test_timeout,`
`86`	`87`	`extra_env={"MPLBACKEND":"macosx"})`
	`88`	`+`
	`89`	`+`
	`90`	`+@pytest.mark.backend('macosx',skip_on_importerror=True)`
	`91`	`+deftest_create_figure_on_worker_thread_fails():`
	`92`	`+`
	`93`	`+defcreate_figure():`
	`94`	`+warn_msg="Matplotlib GUI outside of the main thread will likely fail."`
	`95`	`+err_msg="Cannot create a GUI FigureManager outside the main thread"`
	`96`	`+withpytest.warns(UserWarning,match=warn_msg):`
	`97`	`+withpytest.raises(RuntimeError,match=err_msg):`
	`98`	`+plt.gcf()`
	`99`	`+`
	`100`	`+worker=threading.Thread(target=create_figure)`
	`101`	`+worker.start()`
	`102`	`+worker.join()`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -582,6 +582,16 @@ bool mpl_check_modifier(bool present, PyObject* list, char const* name)`
`582`	`582`	`static PyObject*`
`583`	`583`	`FigureManager_new(PyTypeObject type, PyObject args, PyObject *kwds)`
`584`	`584`	`{`
	`585`	`+if (![NSThreadisMainThread]) {`
	`586`	`+PyErr_SetString(`
	`587`	`+ PyExc_RuntimeError,`
	`588`	`+"Cannot create a GUI FigureManager outside the main thread"`
	`589`	`+"using the MacOS backend. Use a non-interactive"`
	`590`	`+"backend like 'agg' to make plots on worker threads."`
	`591`	`+ );`
	`592`	`+returnNULL;`
	`593`	`+ }`
	`594`	`+`
`585`	`595`	`lazy_init();`
`586`	`596`	`Window* window = [Windowalloc];`
`587`	`597`	`if (!window) {returnNULL; }`

Comments

(0)