Commit02d3c1b

committed

FIX: don't close figures is switch_backend unless really switching

1 parent764cc4a commit02d3c1bCopy full SHA for 02d3c1b

File tree

+16

-2

lines changed

+16

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,6 @@ def switch_backend(newbackend):`
`192`	`192`	`newbackend : str`
`193`	`193`	`The name of the backend to use.`
`194`	`194`	`"""`
`195`		`-close("all")`
`196`		`-`
`197`	`195`	`ifnewbackendisrcsetup._auto_backend_sentinel:`
`198`	`196`	`# Don't try to fallback on the cairo-based backends as they each have`
`199`	`197`	`# an additional dependency (pycairo) over the agg-based backend, and`
`@@ -213,6 +211,8 @@ def switch_backend(newbackend):`
`213`	`211`	`switch_backend("agg")`
`214`	`212`	`rcParamsOrig["backend"]="agg"`
`215`	`213`	`return`
	`214`	`+# have to escape the switch on access logic`
	`215`	`+old_backend=dict.__getitem__(rcParams,'backend')`
`216`	`216`
`217`	`217`	`backend_name= (`
`218`	`218`	`newbackend[9:]ifnewbackend.startswith("module://")`
`@@ -246,6 +246,9 @@ def switch_backend(newbackend):`
`246`	`246`	`# Need to keep a global reference to the backend for compatibility reasons.`
`247`	`247`	`# See https://github.com/matplotlib/matplotlib/issues/6092`
`248`	`248`	`matplotlib.backends.backend=newbackend`
	`249`	`+ifnot (isinstance(old_backend,str)and`
	`250`	`+old_backend.lower()==newbackend.lower()):`
	`251`	`+close("all")`
`249`	`252`
`250`	`253`
`251`	`254`	`defshow(args,*kw):`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,3 +51,14 @@ def test_pyplot_box():`
`51`	`51`	`deftest_stackplot_smoke():`
`52`	`52`	`# Small smoke test for stackplot (see #12405)`
`53`	`53`	`plt.stackplot([1,2,3], [1,2,3])`
	`54`	`+`
	`55`	`+`
	`56`	`+deftest_switch_backend_no_close():`
	`57`	`+plt.switch_backend('agg')`
	`58`	`+fig=plt.figure()`
	`59`	`+fig=plt.figure()`
	`60`	`+assertlen(plt.get_fignums())==2`
	`61`	`+plt.switch_backend('agg')`
	`62`	`+assertlen(plt.get_fignums())==2`
	`63`	`+plt.switch_backend('svg')`
	`64`	`+assertlen(plt.get_fignums())==0`

Comments

(0)