Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed issue with local environment caching routes#842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
michalkleiner merged 1 commit intolivefromroute-caching-issue
Oct 31, 2025

Conversation

@snake14
Copy link
Contributor

Description:

While developing some new routes, I noticed that despite havingCACHING_ENABLED set to false in my local config, I had to manually clear the route cache file each time I made a route path change. The line I changed appears to be doing the opposite of what you would expect and only caching routes when caching is disabled.

Review

@snake14
Copy link
ContributorAuthor

snake14 commentedOct 5, 2025
edited
Loading

I tagged Core Team for review, but I just realised that maybe I should have tagged Websites Team instead.@textagroup Do you know whether there's a specific reason theCACHING_ENABLED constant was set the way it was? To me, it seems like it's doing the opposite of what it should be doing on the line that I'm changing in this PR.

@snake14
Copy link
ContributorAuthor

snake14 commentedOct 13, 2025
edited
Loading

I tagged Core Team for review, but I just realised that maybe I should have tagged Websites Team instead.@textagroup Do you know whether there's a specific reason theCACHING_ENABLED constant was set the way it was? To me, it seems like it's doing the opposite of what it should be doing on the line that I'm changing in this PR.

Any idea about my question above@Frankie75321 ?

@snake14snake14 requested review froma team and removed request fora teamOctober 19, 2025 23:28
@michalkleiner
Copy link
Contributor

Since@tsteur came across the same and arrived at the same solution, I think this tweak is the correct solution. If there's no objection from@textagroup or@Frankie75321 or@sgiehl, I think we can merge this. On the face of it, it makes sense without the negation.

@Frankie75321
Copy link
Contributor

Since@tsteur came across the same and arrived at the same solution, I think this tweak is the correct solution. If there's no objection from@textagroup or@Frankie75321 or@sgiehl, I think we can merge this. On the face of it, it makes sense without the negation.

No objection from me. I came across the same thing.

@snake14
Copy link
ContributorAuthor

Thank you for everyone's feedback. Even with the PR being approved, I don't appear to have permission to merge.@Frankie75321 or someone else with merge permissions for this repo, could you please merge this PR?

@michalkleinermichalkleiner merged commit4e5ebae intoliveOct 31, 2025
1 check passed
@michalkleinermichalkleiner deleted the route-caching-issue branchOctober 31, 2025 06:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@james-hill-matomojames-hill-matomojames-hill-matomo approved these changes

Assignees

No one assigned

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snake14@michalkleiner@Frankie75321@james-hill-matomo

[8]ページ先頭

©2009-2025 Movatter.jp