Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.9k
Fixes #3718 Modify the pop-up conditions of muya-format-picker#3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cfs4819 wants to merge1 commit intomarktext:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dben89x commentedNov 30, 2024
Can we get a review on this so we can merge? This fixes a broken feature, and its scope seems to be relatively simple and contained. The shift key needs to trigger an exception for the muya-format-picker, otherwise it blocks further selection. Repeatedly spamming the "Escape" key is one workaround I guess... |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before: When selecting the text by 'Shift' and 'Arrow keys', the 'muya-format-picker' that pop upon the selected text make it hard to continue selecting by 'Shift + ArrowUp' or 'Shift + ArrowDown' , while 'Shift + ArrowLeft' or 'Shift + ArrowRight' working still.
So I modified the pop up logic of the 'muya-format-picker'. Add code to check if the 'Shift' is still pressed. If so the 'muya-format-picker' won't pop up.