NotificationsYou must be signed in to change notification settings
Fork984
Star7.4k

#3695 Use retainAll() for Set and Map instead of clear()#3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

maxifridge wants to merge1 commit intomapstruct:main

base:main

Choose a base branch

frommaxifridge:#3695-retainAll

Draft

#3695 Use retainAll() for Set and Map instead of clear()#3696

maxifridge wants to merge1 commit intomapstruct:mainfrommaxifridge:#3695-retainAll

Conversation

Copy link

maxifridge commentedSep 4, 2024•
edited
Loading

Implementation of#3695
Using retainAll() for Set and Map targets will minimize the amount of add/remove operations required for these types.
This limits side effects of removing preemptively all elements through clear() to non-Set Collections and Arrays.

A good example of why it is important (and the one that made me work on this issue) : when mapping to a Set property of a Hibernate-managed entity, calling clear() then addAll() effectively triggers requests for all deletions then all additions ; though because of the order of execution in Hibernate, only the newer elements are inserted, the others are deleted.

Use retainAll() for Set and Map instead of clear()

fff78a3

This limits side effects of removing preemptively all elements through clear() to non-Set Collections and Arrays.A good example of why it is important is : when mapping to a Set property of a Hibernate-managed entity, calling clear() then addAll() effectively triggers requests for all deletions then all additions ; though because of the order of execution in Hiberante, only new elements are inserted.