Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added nav-native ETAs#1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
devotaaabel merged 3 commits intomasterfromdevota-fix-etas
Oct 13, 2018
Merged

Added nav-native ETAs#1412

devotaaabel merged 3 commits intomasterfromdevota-fix-etas
Oct 13, 2018

Conversation

@devotaaabel
Copy link
Contributor

No description provided.

@devotaaabeldevotaaabel self-assigned thisOct 12, 2018
@devotaaabeldevotaaabelforce-pushed thedevota-fix-etas branch 2 times, most recently from9a88d64 tof740d12CompareOctober 12, 2018 22:41
@devotaaabeldevotaaabel merged commite6682b1 intomasterOct 13, 2018
@danesfederdanesfeder deleted the devota-fix-etas branchOctober 13, 2018 00:10
publicdoubledurationRemaining() {
return (1 -fractionTraveled()) *routeLeg().duration();
}
publicabstractdoubledurationRemaining();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I believe this is breaking SemVer@devotaaabel@danesfeder

@danesfederdanesfeder mentioned this pull requestOct 24, 2018
11 tasks
@Guardiola31337Guardiola31337 added the backwards incompatibleRequires a SEMVER major version change. labelDec 21, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kevinkreiserkevinkreiserAwaiting requested review from kevinkreiser

2 more reviewers

@Guardiola31337Guardiola31337Guardiola31337 left review comments

@danesfederdanesfederdanesfeder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@devotaaabeldevotaaabel

Labels

backwards incompatibleRequires a SEMVER major version change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devotaaabel@Guardiola31337@danesfeder

[8]ページ先頭

©2009-2025 Movatter.jp