Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Qt6 and MSVC 2019 Support#16611

Open
dpaulat wants to merge10 commits intomapbox:master
base:master
Choose a base branch
Loading
fromdpaulat:feature/qt6-msvc2019

Conversation

@dpaulat
Copy link

@dpaulatdpaulat commentedJun 6, 2021•
edited
Loading

This pull request supports MSVC 2019 and Qt 6.1.0. Backward compatibility with Qt5 has been retained.

  • No visuals have been impacted
  • Tests have been updated for MSVC 2019. A few tests have been disabled, due to Windows platform support. Tests have been verified as passing using MSVC 2019 16.10 (14.29.30037) using the 64-bit compiler, with Qt 6.1.0.
  • No API changes have been made
  • Only Qt (and Windows) functionality should be impacted by this PR

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • tagged@mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdk if this PR adds or updates a public API
  • tagged@mapbox/gl-js if this PR includes shader changes or needs a js port
  • applyneeds changelog label if a changelog is needed (remove label when added)
  • Requires an update to boost headers before merging:Fix proto/generate.hpp for msvc2019 mapbox-gl-native-boost#2

0312birdzhang reacted with heart emoji
@dpaulat
Copy link
Author

@dpaulatdpaulat marked this pull request as ready for reviewJune 6, 2021 15:43
@dpaulatdpaulat requested a review froma team as acode ownerJune 6, 2021 15:43
@ntadej
Copy link
Contributor

This repository is no longer under (open) development. It might be more useful if you port this MR tohttps://github.com/maplibre/maplibre-gl-native.

j-mar reacted with thumbs up emojidpaulat reacted with hooray emoji

@dpaulat
Copy link
Author

This repository is no longer under (open) development. It might be more useful if you port this MR tohttps://github.com/maplibre/maplibre-gl-native.

Great! I was concerned when I saw other pull requests getting ignored. Glad to see there's a fork with an active community. I'll revisit this in the next couple weeks, and reopen the pull request if maplibre is missing the support I need.

@dpaulat
Copy link
Author

This repository is no longer under (open) development. It might be more useful if you port this MR tohttps://github.com/maplibre/maplibre-gl-native.

I have something in-work. It'll take me at least a few days to get a PR ready. There have been a few breaking changes on the master branch. Your PR helps, but I still need to fix some other errors and add at least a zlib dependency for mbtiles.

@ntadej
Copy link
Contributor

Thanks for looking into it!

We probably don't have to fix all at once. My initial goal is to have something build to setup the CI and then fix the remaining issues.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpaulat@ntadej
[8]ページ先頭
©2009-2025 Movatter.jp