This repository was archived by the owner on Aug 8, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.3k
MGLOfflinePackObserver#15851
Open
mateuszmackowiak wants to merge1 commit intomapbox:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
MGLOfflinePackObserver#15851
mateuszmackowiak wants to merge1 commit intomapbox:masterfrommateuszmackowiak:MGLOfflinePackObserver
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
julianrex commentedOct 31, 2019
@mateuszmackowiak thanks for the PR - we will review. FYI we're in the process of transitioning the iOS/macOS code to a separate repo, so please bear with us. |
Contributor
julianrex commentedMar 9, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Apologies for the delay -@mateuszmackowiak are you still interested in this feature?
Update: We will create a new PR on your behalf. |
Author
mateuszmackowiak commentedApr 8, 2020
Hi, I don't see the PR in the new repo? Should I create it? |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue for us is that we do not receive a callback on when the offline maps states are loaded.
When referencing
[MGLOfflineStorage sharedOfflineStorage]for the first time it calls internallyreloadPacksmethod witch is asynchronous with no callback.I know that we can observer the packages by KVO and the for all packages we can request
refreshProgressand then once again observer with KVO the state but synchronising it all is problematic and without proper memory management and removal of kvo observers it will crush.I have made a pull request that extends the
MGLOfflineStorageDelegatewith an optional method- (void)didReloadPackagesForOfflineStorage:(MGLOfflineStorage *)storage;that should inform clearly what was loaded.