Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WEB-5641] chore: sub work item quick menu padding#8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pushya22 merged 1 commit intopreviewfromchore-design-token-enhancements
Dec 17, 2025

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatiaanmolsinghbhatia commentedDec 17, 2025
edited by coderabbitaibot
Loading

Summary by CodeRabbit

  • Style
    • Updated layout spacing on issue list items for improved visual consistency and clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

@anmolsinghbhatiaanmolsinghbhatia self-assigned thisDec 17, 2025
CopilotAI review requested due to automatic review settingsDecember 17, 2025 15:51
@makeplane
Copy link

Linked to Plane Work Item(s)

This comment was auto-generated byPlane

@coderabbitai
Copy link
Contributor

coderabbitaibot commentedDec 17, 2025
edited
Loading

Walkthrough

A single UI layout change adds left padding (pl-2) to a CustomMenu wrapper component in the issue list item. No logic modifications, functionality changes, or behavioral impact—purely a spacing adjustment.

Changes

Cohort / File(s)Change Summary
UI Styling
apps/web/core/components/issues/relations/issue-list-item.tsx
Addpl-2 (left padding) to CustomMenu wrapper div's className

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file, single line modified
  • CSS class addition only; no logic or behavior changes
  • Straightforward spacing adjustment

Poem

🐰 A little padding to the left,
Makes spacing just right, what a deft!
The CustomMenu now breathes with grace,
pl-2 finds its perfect place. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Description check⚠️ WarningThe pull request description is missing entirely, lacking all required sections from the template including Description, Type of Change, Screenshots, Test Scenarios, and References.Add a complete pull request description following the template with at least the Description and Type of Change sections filled out.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly describes the main change: adding padding to the sub work item quick menu component.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branchchore-design-token-enhancements

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and betweenf0b98ce andf481bfe.

📒 Files selected for processing (1)
  • apps/web/core/components/issues/relations/issue-list-item.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Useconst type parameters for more precise literal inference in TypeScript 5.0+
Use thesatisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicitis return types in filter/check functions
UseNoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing inswitch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacyexperimentalDecorators
Useusing declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Usewith { type: "json" } for import attributes; avoid deprecatedassert syntax (TypeScript 5.3/5.8+)
Useimport type explicitly when importing types to ensure they are erased during compilation, respectingverbatimModuleSyntax flag
Use.ts,.mts,.cts extensions inimport type statements (TypeScript 5.2+)
Useimport type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize newSet methods likeunion,intersection, etc., when available (TypeScript 5.5+)
UseObject.groupBy /Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
UsePromise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted,toSpliced,with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields viasuper in classes (TypeScript 5....

Files:

  • apps/web/core/components/issues/relations/issue-list-item.tsx
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Enable TypeScript strict mode and ensure all files are fully typed

Files:

  • apps/web/core/components/issues/relations/issue-list-item.tsx
**/*.{js,jsx,ts,tsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier with Tailwind plugin for code formatting, runpnpm fix:format

Files:

  • apps/web/core/components/issues/relations/issue-list-item.tsx
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately

Files:

  • apps/web/core/components/issues/relations/issue-list-item.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: CodeQL analysis (javascript-typescript)
  • GitHub Check: Build packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/web/core/components/issues/relations/issue-list-item.tsx (1)

162-162:LGTM! Spacing adjustment correctly applied.

The addition ofpl-2 adds appropriate left padding to visually separate the quick menu from the adjacent property component, aligning with the PR objective.


Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR adds left padding (pl-2) to the quick menu container in the RelationIssueListItem component to improve visual spacing. This is a minor UI refinement targeting the menu that appears at the end of issue relation list items.

  • Addspl-2 (padding-left) class to the CustomMenu container div

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

/>
</div>
<divclassName="flex-shrink-0 text-13">
<divclassName="pl-2flex-shrink-0 text-13">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The padding-left (pl-2) has been added to this menu container. Consider whether the similar CustomMenu in SubIssuesListItem (apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx line 185) should also have this padding for consistency. The SubIssuesListItem has an identical layout structure with properties followed by the CustomMenu, but lacks this pl-2 class.

Copilot uses AI. Check for mistakes.
@pushya22pushya22 merged commit9b90fbf intopreviewDec 17, 2025
17 of 18 checks passed
@pushya22pushya22 deleted the chore-design-token-enhancements branchDecember 17, 2025 15:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@aaryan610aaryan610aaryan610 approved these changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmolsinghbhatia@aaryan610@pushya22

[8]ページ先頭

©2009-2025 Movatter.jp