- Notifications
You must be signed in to change notification settings - Fork829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add support to multiples webhook endpoints for Microsoft Teams notification service#5508
Merged
wangxiaoyou1993 merged 2 commits intomage-ai:masterfrommesserzen:enhancement/support-teams-webhook-listOct 26, 2024
Merged
Add support to multiples webhook endpoints for Microsoft Teams notification service#5508
wangxiaoyou1993 merged 2 commits intomage-ai:masterfrommesserzen:enhancement/support-teams-webhook-listOct 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
messerzen added a commit to messerzen/mage-ai that referenced this pull requestOct 18, 2024
Updating the documentation in case this PR be mergedmage-ai#5508cc:@wangxiaoyou1993
7 tasks
wangxiaoyou1993 approved these changesOct 26, 2024
wangxiaoyou1993 pushed a commit that referenced this pull requestOct 26, 2024
# DescriptionUpdating the documentation for microsoft teams notification in case[this PR](#5508) be merged.# How Has This Been Tested?Only with preview mode.- [ ] Test A- [ ] Test B# Checklist- [ ] The PR is tagged with proper labels (bug, enhancement, feature,documentation)- [ ] I have performed a self-review of my own code- [ ] I have added unit tests that prove my fix is effective or that myfeature works- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentationcc:@wangxiaoyou1993
6 tasks
wangxiaoyou1993 added a commit that referenced this pull requestDec 4, 2024
# Description<!-- Please include a summary of the change and which issue is fixed.Please also include relevant motivation and context.List any dependencies that are required for this change.-->Bump up version to 0.9.75<!-- Release notes generated using configuration in .github/release.ymlat master -->## What's Changed### 🎉 Exciting New Features* Airtable Destination by@TalaatHasanin in#5454* [hw] Support Mage in Python 3.11 and 3.12 by@csharplus in#5393* Add postgres client package by@jx2lee in#5486* [enhancement] Update Elasticsearch + verify_certs connection option by@syepes in#5462* [enhancement] adds support of _op_type for bulk operations ofdestinations by@syepes in#5482* [enhancement] Elasticsearch support of _op_type for bulk operations by@syepes in#5471* Add support to multiples webhook endpoints for Microsoft Teamsnotification service by@messerzen in#5508* [hw] Update Redshift connector to enable merge load and correct rowcount by@csharplus in#5522### 🐛 Bug Fixes* [xh]Pass OpenAI API key to OpenAI Library by@matrixstone in#5430* [jk] Fix error detail log parsing by@johnson-mage in#5443* [jk] Render json objects in block outputs as string instead of nestedtable by@johnson-mage in#5450* [jk] Block output table cell overflow by@johnson-mage in#5451* [Bug] Updated SalesForce source to handle multiple date formats by@tolson17 in#5493* [jk] Handle encoded page_block_layouts and block_outputs routes by@johnson-mage in#5544* [jk] Revert name of test environment by@johnson-mage in#5478* [hw] Correct the SSL settings in the nats configuration template by@csharplus in#5579* Fix encoding in GCS Integration by@TalaatHasanin in#5447* [enhancement] Elasticsearch - Align the doc publishing with theStandard (batch) by@syepes in#5510* [Enhancement] io/base.py: add Excel support by@LucasGrugru in#5542* [hw] Update deltalake to a recent version `0.20.2` by@csharplus in#5541* bugfix/#5562 python data exporter failed insert 2d array to postgresby@sugimiyanto in#5563* Fix unable to pass extra parameters to psycopg2 in Postgres connectorby@kanenorman in#5449* [hw] Avoid throwing exceptions when `block_type` is None by@csharplusin#5439* Fix load data in GCS integration by@TalaatHasanin in#5467### 💅 Enhancements & Polish* [xh] Update python version to fix vulnerabilities by@matrixstone in#5523* [jk] Display ID in block runs table by@johnson-mage in#5457* [Oracle DB] Modify inefficient code that converts dataframe to list oftuples by@farmboy-dev in#5502* [jk] Allow user to set number of lines displayed for block outputsample preview by@johnson-mage in#5485* [hw] Use `self.logger.debug` to replace `print` to make code clean by@csharplus in#5494* Updated Facebook Ads SDK to 20.0.2 by@jonatansthlmstratlab in#5437### Other Changes* Update documentation for Git in Mage in the Getting Started section by@Lennardvb in#5459* [hw] Use the built-in IntEnum instead of creating a new class by@csharplus in#5433* [hw] Add time delay to avoid getting the same file timestamp formultiple changes by@csharplus in#5499* Update text in documentation about enabling HTTPS in AWS by@Lennardvbin#5517* Fix typos in compute-resource.mdx by@mvillaizan in#5519* Update alerting-teams.mdx for multiples webhooks. by@messerzen in#5511* Update README.md by@neubert-analytics in#5441* Typo fix ai-client.mdx by@MageKai in#5582* Add information regarding feature dependency to docs by@oscarlofwenhamn in#5584## New Contributors*@jonatansthlmstratlab made their first contribution in#5437*@Lennardvb made their first contribution in#5459*@syepes made their first contribution in#5471*@jx2lee made their first contribution in#5486*@mvillaizan made their first contribution in#5519*@farmboy-dev made their first contribution in#5502*@tolson17 made their first contribution in#5493*@neubert-analytics made their first contribution in#5441*@kanenorman made their first contribution in#5449*@LucasGrugru made their first contribution in#5542*@sugimiyanto made their first contribution in#5563*@oscarlofwenhamn made their first contribution in#5584**Full Changelog**:0.9.74...0.9.75# How Has This Been Tested?<!-- Please describe the tests that you ran to verify your changes.Provide instructions so we can reproduce.-->- [x] Basic tests locally# Checklist- [x] The PR is tagged with proper labels (bug, enhancement, feature,documentation)- [x] I have performed a self-review of my own code- [ ] I have added unit tests that prove my fix is effective or that myfeature works- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentationcc:<!-- Optionally mention someone to let them know about this pull request-->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#5507
This change introduces support for multiple Microsoft Teams webhook URLs within the notification configuration. The previous structure allowed for a single webhook URL, as follows:
The updated structure enables the configuration of multiple webhook URLs:
This enhancement allows users to send notifications to multiple Teams channels simultaneously, providing greater flexibility in notification management.
Additionally, the new implementation retains compatibility with the existing configuration model. This ensures that current users can continue to operate without disruption, as the system will still recognize and function with the single webhook URL format.
PR for documentation update:#5511
**The test was updated to match the new data type
List[str]
How Has This Been Tested?
It was testing with 3 scenarios.
1st - Single webhook as string
2nd - Single webhook as list
3rd - Two webhooks as list
Here's some evidences for multiple webhooks (same message was sent to both channels):


Channel 1
Channel 2
Checklist
cc:
@wangxiaoyou1993