New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[dy] Fix elasticsearch destination#4687

Merged

Mar 1, 2024

Merged

Mar 1, 2024

Conversation

Copy link

Contributor

Fix a couple of issues with the Elasticsearch destination:

Test connection will fail if theproperties field doesn't exist, so adding a safe get there.
Thelogger.debug command was causing an error when using themetadata_fields config value.

The PR is tagged with proper labels (bug, enhancement, feature, documentation)
I have performed a self-review of my own code
I have added unit tests that prove my fix is effective or that my feature works
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
If new documentation has been added, relative paths have been added to the appropriate section ofdocs/mint.json

[dy] Fix elasticsearch destination

c48e5df

dy46 requested a review fromwangxiaoyou1993

dy46 commented

Comment on lines +16 to +27

		TargetElasticsearch(config=self.config, logger=self.logger).listen_override(
		file_input=open(self.input_file_path, 'r')
		)

		def test_connection(self) -> None:
		target = TargetElasticsearch(config=self.config,
		logger=self.logger)
		client = ElasticSink(target=target,
		stream_name='test',
		schema={},
		key_properties=None,).client
		target = TargetElasticsearch(config=self.config, logger=self.logger)
		client = ElasticSink(
		target=target,
		stream_name='test',
		schema={},
		key_properties=None,
		).client