- Notifications
You must be signed in to change notification settings - Fork2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Create msbuild.ymlThis appears to be an in-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing.#953
base:develop
Are you sure you want to change the base?
Conversation
Please provide a description and rationale for the pull request. |
This appears to be an in-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing. Problem is, it doesn't work in its current form. @MC-MAGA your own test run with this workflow failed (https://github.com/MC-MAGA/zlib/actions/runs/8314919535) in the nuget step. I don't know nuget, so no idea what it is supposed to do in this context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing.
@MC-MAGA can you get the workflow operating properly? |
Neustradamus commentedMay 27, 2024
@MC-MAGA: Have you progressed on your PR? |
cjee21 commentedMar 3, 2025
Something like the following should work. name:MSBuildon:[push, pull_request]jobs:Windows:runs-on:windows-lateststrategy:matrix:architecture:[ Win32, x64, ARM64 ]fail-fast:falsesteps: -name:Checkoutuses:actions/checkout@v4 -name:Add msbuild to PATHuses:microsoft/setup-msbuild@v2 -name:Buildrun:msbuild -p:Configuration=Release -p:Platform=${{ matrix.architecture }} ${{ github.workspace }}\contrib\vstudio\vc17\zlibvc.sln -warnaserror |
Anyone noticed that the cmake actions actually call msbuild internally? |
cjee21 commentedMar 4, 2025
Anyone noticed that this PR actually looks like a typical spam PR? Anyway, although I am not familiar with cmake, it does use msbuild but using project files that it generates. So the only purpose of adding a msbuild workflow would be to check the project files in contrib directory and not to check whether zlib code can be built by msbuild. This is likely not something that is wanted according to the definition of the contrib directory. |
No description provided.