Commitc86cbbb

authored and

committed

fix(inspect): escape identifiers that are lua keywords (neovim#19898)

A lua keyword is not a valid table identifier

1 parentd459b66 commitc86cbbbCopy full SHA for c86cbbb

File tree

+31

-1

lines changed

+31

-1

lines changed

Lines changed: 31 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,38 @@ local function escape(str)`
`89`	`89`	`)`
`90`	`90`	`end`
`91`	`91`
	`92`	`+-- List of lua keywords`
	`93`	`+localluaKeywords= {`
	`94`	`+ ['and']=true,`
	`95`	`+ ['break']=true,`
	`96`	`+ ['do']=true,`
	`97`	`+ ['else']=true,`
	`98`	`+ ['elseif']=true,`
	`99`	`+ ['end']=true,`
	`100`	`+ ['false']=true,`
	`101`	`+ ['for']=true,`
	`102`	`+ ['function']=true,`
	`103`	`+ ['goto']=true,`
	`104`	`+ ['if']=true,`
	`105`	`+ ['in']=true,`
	`106`	`+ ['local']=true,`
	`107`	`+ ['nil']=true,`
	`108`	`+ ['not']=true,`
	`109`	`+ ['or']=true,`
	`110`	`+ ['repeat']=true,`
	`111`	`+ ['return']=true,`
	`112`	`+ ['then']=true,`
	`113`	`+ ['true']=true,`
	`114`	`+ ['until']=true,`
	`115`	`+ ['while']=true,`
	`116`	`+}`
	`117`	`+`
`92`	`118`	`localfunctionisIdentifier(str)`
`93`		`-returntype(str)=='string'andnotnotstr:match('^[_%a][_%a%d]*$')`
	`119`	`+returntype(str)=='string'`
	`120`	`+-- identifier must start with a letter and underscore, and be followed by letters, numbers, and underscores`
	`121`	`+andnotnotstr:match('^[_%a][_%a%d]*$')`
	`122`	`+-- lua keywords are not valid identifiers`
	`123`	`+andnotluaKeywords[str]`
`94`	`124`	`end`
`95`	`125`
`96`	`126`	`localflr=math.floor`

Comments

(0)