- Notifications
You must be signed in to change notification settings - Fork78
prevent build issues with using --enable-jtag-repl=y#265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Define USB_SERIAL_JTAG_PACKET_SZ_BYTES to prevent errors when building with --enable-jtag-repl=y
Collaborator
kdschlosser commentedJan 20, 2025
That's right. I forgot to add that macro. in ESP-IDF 5.2.2 that macro is available but in 5.2.3 it is not. MicroPython officially only supports up to 5.2.2 I believe. We are using 5.2.3. Thanks for the fix, I had completely forgot to add it. |
c6b57d7 intolvgl-micropython:main 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
0ut4t1m3 commentedJan 20, 2025
No problems mate, glad to help. |
Collaborator
kdschlosser commentedJan 20, 2025
thanks m8 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kevin, I've noticed that at least the S3 and C6 series are hitting the error raised in#236 when enabling the JTAG REPL and I have been manually editing mpconfigboard.h for each target.
This PR ensures USB_SERIAL_JTAG_PACKET_SZ_BYTES is defined during the build when enable-jtag-repl=y.