Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes for the ESP32 S3 build#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kdschlosser merged 1 commit intolvgl-micropython:mainfromlukier:fix-for-esp32-s3
Jan 19, 2025

Conversation

@lukier
Copy link
Contributor

I couldn't build for ESP32-S3 last night, so I fixed the code in a couple of places.

@kdschlosser
Copy link
Collaborator

I made some comments on the changes that are proposed.

I had made changes before I realized that I had forgotten to add the source file to the cmake script which was what was causing some of the issues. I couldn't understand why there were some of the issues and once I found out what the issue were being caused by I did not revert any of the changes I made as sleep was more important at the time.

@lukier
Copy link
ContributorAuthor

Oh sorry, I've just noticed that by the time I've created the pull-request you've already started fixing those issues.

Sorry for the confusion. You can close this PR if you want.

@kdschlosser
Copy link
Collaborator

No No. correct those couple of things and I will merge it because I do want to revert some of it back to the way it was originally. You spent the time to do the work I basically didn't want to do. LOL.

Just need to update a few things so it can be merged.

@lukier
Copy link
ContributorAuthor

No No. correct those couple of things and I will merge it because I do want to revert some of it back to the way it was originally. You spent the time to do the work I basically didn't want to do. LOL.

Just need to update a few things so it can be merged.

No problem, but I don't see any comments in the code review, where are they?

@kdschlosser
Copy link
Collaborator

I was also messing around with the CI when I was making the changes I was making... It was taking too damned long for the CI to run. I changed it so instead of it using GitHub's servers for the CI it is using my server to run the CI. It is now able to run the builds in 4 minutes when it was taking 14 minutes to complete.

lukier reacted with thumbs up emoji

Copy link
Collaborator

@kdschlosserkdschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I forgot to click on the finish button for them to show up.

@kdschlosser
Copy link
Collaborator

It's running the CI now.

lukier reacted with thumbs up emoji

@kdschlosserkdschlosser merged commit36c0759 intolvgl-micropython:mainJan 19, 2025
5 checks passed
@lukierlukier deleted the fix-for-esp32-s3 branchJanuary 19, 2025 10:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kdschlosserkdschlosserkdschlosser requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukier@kdschlosser

[8]ページ先頭

©2009-2025 Movatter.jp