Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18
Add GitHub notifications namespace#477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds support for GitHub's notifications API by introducing a new notifications namespace. The implementation follows the established patterns in the codebase for namespaces and models.
Key changes:
- Added
GitHubNotificationModelwith nested_Subjectmodel to represent notification data - Implemented
GitHubNotificationsNamespacewith alist()method supporting filtering parameters - Integrated the notifications namespace into the main
GitHubAPI class
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
aiogithubapi/models/notification.py | Defines notification data models with fields for id, repository, subject, reason, and read status |
aiogithubapi/namespaces/notifications.py | Implements the notifications namespace with list method supporting pagination and filtering |
aiogithubapi/github.py | Integrates notifications namespace into the main API class |
aiogithubapi/__init__.py | Exports GitHubNotificationModel for public API access |
tests/namespaces/test_notifications.py | Adds test coverage for the list notifications endpoint |
tests/fixtures/notifications.json | Provides mock response data for notifications tests |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ludeeus commentedNov 9, 2025
@copilot open a new pull request to apply changes based on the comments inthis thread |
…ns namespace (#478)* Initial plan* Apply review feedback: use consistent type annotations in notifications namespaceCo-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>* Update aiogithubapi/namespaces/notifications.py* Update aiogithubapi/namespaces/notifications.py---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>Co-authored-by: Joakim Sørensen <joasoe@proton.me>
Description
Adds notification namespace to list notifications.
Type of change
Checklist
scripts/test)scripts/lint)