- Notifications
You must be signed in to change notification settings - Fork278
optimize /runOpenApi to allow pre-dereferencing OpenAPI Spec#750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
allow passing in an already dereferenced OpenAPI Document for pluginsthat have large openapi specs like github. This takes the runtime forGithub from over 10s to ~1s on an M1 Max.Adjust the github plugin to use this new capability by dereferencing onplugin initialization, passing the derefed document to the runOpenApifunction.
👷 Deploy request forlowcoder-cloud pending review.Visit the deploys page to approve it
|
FalkWolsky approved these changesMar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you very much for this truly helpful contribution!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR fixes an issue where the
openApiplugin would try to dereference theOpenAPI spec for each plugin when the plugin isrun rather than on
initialization.
I did not attempt to fix the issue for every plugin, I simply wanted to start with
the one that was affecting me the most, the Github plugin. But this PR
adds the capability to allow any OpenAPI plugin to now use a pre-dereferenced
OpenAPI.Documentinstead of de-referencing during runtime.Before:
/pluginsaveraged19.472ms before the change/runPluginQueryaveraged6867.030ms before the changeAfter:
/pluginsaveraged20.302ms after the change/runPluginQueryaveraged1533.787ms after the changeThat's a 77.67% decrease in runtime for the
/runPluginQuery, but a 4.27% increase for the/pluginsquery.Without the 77ms outlier the results are much nicer:
54.84% decrease in runtime for the
/pluginsquery and a77.67% decrease in runtime for the/runPluginQuery