- Notifications
You must be signed in to change notification settings - Fork278
Dev -> Main - fixing Publishing behaviour#717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Revert App View Validation For Non-Published Apps
Added disabledCollision flag in app dsl to handle layers in editor
Adds the ability to select the left or right position for the close button in the drawer component.
Drawer Close Button Left or Right
netlifybot commentedFeb 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forlowcoder-cloud ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
netlifybot commentedFeb 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forlowcoder-test canceled.
|
encorearon pushed a commit to encorearon/lowcoder that referenced this pull requestMar 6, 2024
Dev -> Main - fixing Publishing behaviour
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a Button "Publish"... And ... the most normal thing to check in the backend before we deliver an app /view is ... "is it published???"
We introduced this check in 2.3.1 - which lead into the situation, that most of your apps may have not been effectively published. They was in edit / preview mode - but our /view endpoint was "generous" to show the latest version anyhow.
What was our mistake: We should have applied an automatic redirect for example or a warning message - not just a 400 Bad request.
However, we take this momentum as chance to introduce in the next Version (2.4.x) the "normal Publishing behaviour including this check and semantic versioning". That will give you then time to publish all apps and check it, as we communicate it then as Breaking Change.
As for today, we un-check the check and will update the 2.3.1 Docker images - so in some minutes all should work fine.