Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

nav component issue fixes, component updates in progress#700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

imtananikhwa
Copy link
Contributor

@imtananikhwaimtananikhwa commentedFeb 22, 2024
edited
Loading

FEEDBACK:

Nav Component - Text-Size have to be respected, Margin and Padding too. Style for the sub-menu entries should be possible to set individually. Background Image (and its siblings) should be added
Link Component - Padding must be respected vertically correct, Border Radius must be respected
Mention Component - Text-Size have to be respected, Input field should have same height as standard input field height
Dropdown - 2 times border-radius and border-color to set, one time is enough, Border-Width have to be respected, Text-Weight have to be respected
Toggle Button - Padding must be respected horizontally correct, Border-Width have to be respected

Following changes have been made:

Nav Component:
Text size, margin and padding issue. Didn't change sub menu styling

Link Component:
Padding and border radius fixed

Mention component:
Text size issue fixed

Dropdown:
duplicate style properties removed.
Styling showing when display when label only is selected

Toggle Button:
Padding and Border width working

Circle Progress:
Circle progress style type and variable created to ensure relevant styles are shown
Styles and their control added

File Component: (fileComp.tsx)
Styles and their control added

Known Issues:

Nav component:
Padding when increased doesn't change the overall component height.

Dropdown:
styling not working when display with label only property is disabled.

Progress:
none of the border styling is working ==> will look into the antd documentation and updated type accordingly

Other:
Added "Montserrat" google font so font family property can be tested for thecomponents.

@FalkWolskyFalkWolsky merged commitb31e606 intolowcoder-org:style-changes-imtamanFeb 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imtananikhwa@FalkWolsky

[8]ページ先頭

©2009-2025 Movatter.jp