Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix helm template encryption env var names#678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FalkWolsky merged 1 commit intolowcoder-org:devfromsseide:bugfix
Feb 15, 2024

Conversation

sseide
Copy link
Contributor

Proposed changes

Looking at the name of the env vars created within the kubernetes secret via Helm and checking the code i suspect the
to environment variables defining the DB encryption secrets to be named wrong. The letter "E" was moved to the wrong place.

This fix changes the environment names to match the ones in the docker compose yaml files / docker readme / app.json file.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put anx in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put anx in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlifyNetlify
Copy link

netlifybot commentedFeb 13, 2024

👷 Deploy request forlowcoder-cloud pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commitd1c9efa

@FalkWolskyFalkWolsky changed the base branch frommain todevFebruary 15, 2024 06:01
Copy link
Contributor

@FalkWolskyFalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh! Thank you very much!! That is indeed true and a great help. We did oversee it.

@FalkWolskyFalkWolsky merged commit3883666 intolowcoder-org:devFeb 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FalkWolskyFalkWolskyFalkWolsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sseide@FalkWolsky

[8]ページ先頭

©2009-2025 Movatter.jp