Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix table row selection for applications created in older versions of Lowcoder#1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FalkWolsky merged 4 commits intolowcoder-org:devfromnangelov-eti:fix/table-row-selection
Nov 27, 2024
Merged

Fix table row selection for applications created in older versions of Lowcoder#1346

FalkWolsky merged 4 commits intolowcoder-org:devfromnangelov-eti:fix/table-row-selection
Nov 27, 2024

Conversation

nangelov-eti
Copy link

Proposed changes

We found that adding a simple check resolved the issue. When a table row contains null values, we were unable to select the row or interact with the button in that row. The root cause was that whenvalue is null or undefined, callingObject.keys(value) tries to convert it to an object, resulting in the error:TypeError: Cannot convert undefined or null to object at Function.keys. To address this, we added a check to ensure value is neither null nor undefined before attempting to access its keys.

Please review the changes for any potential side effects, though I haven't observed any. This should enhance backwards compatibility.

This PRfixes#1332

Screenshot 2024-11-27 111509
Screenshot 2024-11-27 111656

Types of changes

What types of changes does your code introduce to Lowcoder?
Put anx in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put anx in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlifyNetlify
Copy link

netlifybot commentedNov 27, 2024
edited
Loading

👷 Deploy request forlowcoder-test pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commite2a9ad0

Copy link
Contributor

@FalkWolskyFalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh! You found it. This is truly amazing and we feel very thankful that you offered this solution!

nangelov-eti reacted with thumbs up emoji
@FalkWolskyFalkWolsky merged commit6bf8b1c intolowcoder-org:devNov 27, 2024
3 checks passed
@nangelov-etinangelov-eti deleted the fix/table-row-selection branchNovember 27, 2024 15:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FalkWolskyFalkWolskyFalkWolsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nangelov-eti@FalkWolsky@Nangelov7

[8]ページ先頭

©2009-2025 Movatter.jp