- Notifications
You must be signed in to change notification settings - Fork278
Update helm k8s autoscaling api version to v2#1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
netlifybot commentedSep 16, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
👷 Deploy request forlowcoder-test pending review.Visit the deploys page to approve it
|
FalkWolsky approved these changesSep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you very much!! This is a truly valuable contribution!
87037da
intolowcoder-org:dev 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve Helm Chart - Replace outdated kubernetes api version to latest
apiVersion
for HorizontalPodAutoscaler resources fromautoscaling/v2beta1
toautoscaling/v2
.v2beta1
API, replacing it with the latest stablev2
API.Types of changes
Checklist
Further comments
Starting from Kubernetes v1.22, the
autoscaling/v2beta1
API has been deprecated and is no longer available in subsequent versions like v1.25 and beyond. As of 2024, migrating to theautoscaling/v2
API is necessary to ensure compatibility with Kubernetes clusters that have removed support for the beta version.