Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow dynamic/conditional styles + Refactor logic for applying theme on each comp#1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FalkWolsky merged 4 commits intodevfromdynamic-style-fixes
Aug 27, 2024

Conversation

raheeliftikhar5
Copy link
Collaborator

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put anx in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put anx in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlifyNetlify
Copy link

netlifybot commentedAug 12, 2024
edited
Loading

Deploy Preview forlowcoder-test ready!

NameLink
🔨 Latest commit906df19
🔍 Latest deploy loghttps://app.netlify.com/sites/lowcoder-test/deploys/66cdf3d33b0a8200080efd62
😎 Deploy Previewhttps://deploy-preview-1105--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@raheeliftikhar5raheeliftikhar5 changed the title[WIP] Allow dynamic styles + Refactor theme applying in each compAllow dynamic/conditional styles + Refactor logic for applying theme on each compAug 13, 2024
@raheeliftikhar5raheeliftikhar5 marked this pull request as ready for reviewAugust 13, 2024 16:19
Copy link
Contributor

@FalkWolskyFalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you very much for this important improvement! It helps a lot to preserve an important ability.

@FalkWolskyFalkWolsky merged commit64d5bbd intodevAug 27, 2024
7 checks passed
@FalkWolskyFalkWolsky deleted the dynamic-style-fixes branchAugust 27, 2024 18:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FalkWolskyFalkWolskyFalkWolsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@raheeliftikhar5@FalkWolsky

[8]ページ先頭

©2009-2025 Movatter.jp