- Notifications
You must be signed in to change notification settings - Fork254
Use API service health check for k8s deployments#1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Use API service health check for k8s deployments#1075
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👷 Deploy request forlowcoder-cloud pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you very much Alexey! A while ago we (FINALLY) introduced this endpoint at the API for ... pretty much exactly this reason! Now step by step we need to update the deployment files to make use of. Your contribution is much welcome!
90e4e81
intolowcoder-org:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Proposed changes
This pull request addresses an issue with the lowcoder deployment using the current Helm charts, where the api-service pod restarts due to the readiness probe returning a 404 NOT_FOUND error. The error occurs as follows:
2024-07-30 00:10:55.579 ERROR o.l.api.framework.exception.GlobalExceptionHandler#lambda$doLog$8:155 GET /actuator/health [parallel-1]: org.springframework.web.server.ResponseStatusException: 404 NOT_FOUND
To resolve this issue, this PR updates the readiness and liveness probes to use the health check endpoint as documented in theLowcoder self-hosting setup guide.
This change ensures that the probes correctly check the health of the api-service and prevent unnecessary pod restarts.
Since health check endpoint was introduced in v2.4.1, previous lowcoder versions will not work.
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.