Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use API service health check for k8s deployments#1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FalkWolsky merged 1 commit intolowcoder-org:mainfromAlexeyPetroff:bugfix/k8s-liveness-readiness-fix
Aug 6, 2024
Merged

Use API service health check for k8s deployments#1075

FalkWolsky merged 1 commit intolowcoder-org:mainfromAlexeyPetroff:bugfix/k8s-liveness-readiness-fix
Aug 6, 2024

Conversation

AlexeyPetroff
Copy link
Contributor

@AlexeyPetroffAlexeyPetroff commentedJul 30, 2024
edited
Loading

Proposed changes

This pull request addresses an issue with the lowcoder deployment using the current Helm charts, where the api-service pod restarts due to the readiness probe returning a 404 NOT_FOUND error. The error occurs as follows:

2024-07-30 00:10:55.579 ERROR o.l.api.framework.exception.GlobalExceptionHandler#lambda$doLog$8:155 GET /actuator/health [parallel-1]: org.springframework.web.server.ResponseStatusException: 404 NOT_FOUND

To resolve this issue, this PR updates the readiness and liveness probes to use the health check endpoint as documented in theLowcoder self-hosting setup guide.
This change ensures that the probes correctly check the health of the api-service and prevent unnecessary pod restarts.
Since health check endpoint was introduced in v2.4.1, previous lowcoder versions will not work.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put anx in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put anx in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlifyNetlify
Copy link

netlifybot commentedJul 30, 2024

👷 Deploy request forlowcoder-cloud pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commit640522a

@AlexeyPetroff
Copy link
ContributorAuthor

#999

@AlexeyPetroffAlexeyPetroff changed the base branch frommain todevJuly 31, 2024 03:30
@AlexeyPetroffAlexeyPetroff changed the base branch fromdev tomainJuly 31, 2024 03:30
Copy link
Contributor

@FalkWolskyFalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you very much Alexey! A while ago we (FINALLY) introduced this endpoint at the API for ... pretty much exactly this reason! Now step by step we need to update the deployment files to make use of. Your contribution is much welcome!

@FalkWolskyFalkWolsky merged commit90e4e81 intolowcoder-org:mainAug 6, 2024
2 checks passed
@AlexeyPetroffAlexeyPetroff deleted the bugfix/k8s-liveness-readiness-fix branchAugust 11, 2024 23:38
@adnanqaopsadnanqaops mentioned this pull requestSep 9, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FalkWolskyFalkWolskyFalkWolsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AlexeyPetroff@FalkWolsky

[8]ページ先頭

©2009-2025 Movatter.jp