Commitd8ede2f

committed

fix js query trigger on page load when used exposed variables are referred e.g. utils, toast, input1

1 parent1b98505 commitd8ede2fCopy full SHA for d8ede2f

File tree

+11

-9

lines changed

+11

-9

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1692,11 +1692,12 @@ class CodeNode extends AbstractNode {`
`1692`	`1692`	`// if query is dependent on itself, mark as ready`
`1693`	`1693`	`if (pathsArr?.[0] === options?.queryName)`
`1694`	`1694`	`return;`
	`1695`	`+ // TODO: check if this is needed after removing lazy load`
`1695`	`1696`	`// wait for lazy loaded comps to load before executing query on page load`
`1696`		`- if (value && !Object.keys(value).length && paths.size) {`
`1697`		`- isFetching = true;`
`1698`		`- ready = false;`
`1699`		`- }`
	`1697`	`+//if (value && !Object.keys(value).length && paths.size) {`
	`1698`	`+// isFetching = true;`
	`1699`	`+// ready = false;`
	`1700`	`+//}`
`1700`	`1701`	`if (_.has(value, IS_FETCHING_FIELD)) {`
`1701`	`1702`	`isFetching = isFetching \|\| value.isFetching === true;`
`1702`	`1703`	`}`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -176,11 +176,12 @@ export class CodeNode extends AbstractNode<ValueAndMsg<unknown>> {`
`176`	`176`	`// if query is dependent on itself, mark as ready`
`177`	`177`	`if(pathsArr?.[0]===options?.queryName)return;`
`178`	`178`
	`179`	`+// TODO: check if this is needed after removing lazy load`
`179`	`180`	`// wait for lazy loaded comps to load before executing query on page load`
`180`		`-if(value&&!Object.keys(value).length&&paths.size){`
`181`		`-isFetching=true;`
`182`		`-ready=false;`
`183`		`-}`
	`181`	`+//if (value && !Object.keys(value).length && paths.size) {`
	`182`	`+// isFetching = true;`
	`183`	`+// ready = false;`
	`184`	`+//}`
`184`	`185`	`if(_.has(value,IS_FETCHING_FIELD)){`
`185`	`186`	`isFetching=isFetching\|\|value.isFetching===true;`
`186`	`187`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ function QueryView(props: QueryViewProps) {`
`335`	`335`	`){`
`336`	`336`	`setTimeout(()=>{`
`337`	`337`	`comp.dispatch(deferAction(executeQueryAction({})));`
`338`		`-},300);`
	`338`	`+},600);`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`if(getTriggerType(comp)==="onTimeout"){`

Comments

(0)