Commit9003007

committed

fixed global data variables lost while navigating apps

1 parenta59626b commit9003007Copy full SHA for 9003007

File tree

-4

lines changed

client/packages/lowcoder/src
- comps/generators
  - hookToComp.tsx
- pages/editor
  - appEditorInternal.tsx

-4

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ export function hookToComp(useHookFn: () => JSONObject) {`
`13`	`13`	`}),`
`14`	`14`	`(comp)=>{`
`15`	`15`	`consthookValue=useHookFn();`
	`16`	`+`
`16`	`17`	`useEffect(()=>{`
`17`	`18`	`comp.children.value.dispatchChangeValueAction(hookValue);`
`18`	`19`	`},[hookValue]);`
`@@ -33,8 +34,10 @@ export function hookToStateComp(useHookFn: () => JSONObject) {`
`33`	`34`	`(comp)=>{`
`34`	`35`	`consthookValue=useHookFn();`
`35`	`36`	`useEffect(()=>{`
`36`		`-comp.children.stateValue.dispatchChangeValueAction(hookValue);`
`37`		`-},[hookValue]);`
	`37`	`+if(hookValue!==comp.children.stateValue.getView()){`
	`38`	`+comp.children.stateValue.dispatchChangeValueAction(hookValue);`
	`39`	`+}`
	`40`	`+},[]);`
`38`	`41`	`returnnull;`
`39`	`42`	`}`
`40`	`43`	`);`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ function useSaveComp(`
`44`	`44`	`constdispatch=useDispatch();`
`45`	`45`	`const[prevComp,setPrevComp]=useState<Comp>();`
`46`	`46`	`const[prevJsonStr,setPrevJsonStr]=useState<string>();`
	`47`	`+const[prevAppId,setPrevAppId]=useState<string>();`
`47`	`48`
`48`	`49`	`useEffect(()=>{`
`49`	`50`	`if(readOnly\|\|blockEditing){`
`@@ -54,7 +55,7 @@ function useSaveComp(`
`54`	`55`	`}`
`55`	`56`	`constcurJson=comp.toJsonValue();`
`56`	`57`	`constcurJsonStr=JSON.stringify(curJson);`
`57`		`-if(prevJsonStr===curJsonStr){`
	`58`	`+if(prevJsonStr===curJsonStr\|\|(Boolean(prevAppId)&&prevAppId!==applicationId)){`
`58`	`59`	`return;`
`59`	`60`	`}`
`60`	`61`	`// the first time is a normal change, the latter is the manual update`
`@@ -70,7 +71,8 @@ function useSaveComp(`
`70`	`71`	`}`
`71`	`72`	`setPrevComp(comp);`
`72`	`73`	`setPrevJsonStr(curJsonStr);`
`73`		`-},[comp,applicationId,prevComp,prevJsonStr,readOnly,dispatch]);`
	`74`	`+setPrevAppId(applicationId);`
	`75`	`+},[comp,prevAppId,applicationId,prevComp,prevJsonStr,readOnly,dispatch]);`
`74`	`76`	`}`
`75`	`77`
`76`	`78`	`interfaceAppEditorInternalViewProps{`

Comments

(0)