Commit5df453d

committed

fix infinite loop when 0 environments

1 parentb4c50b3 commit5df453dCopy full SHA for 5df453d

File tree

-9

lines changed

client/packages/lowcoder/src
- pages/setting/environments
  - EnvironmentsList.tsx
- redux/selectors
  - enterpriseSelectors.ts

-9

lines changed

Lines changed: 3 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-importReact,{useState,useEffect}from"react";`
	`1`	`+importReact,{useState,useEffect,useRef}from"react";`
`2`	`2`	`import{Typography,Alert,Input,Button,Space,Empty,Card,Spin,Row,Col,Tooltip,Badge}from"antd";`
`3`	`3`	`import{SearchOutlined,CloudServerOutlined,SyncOutlined,PlusOutlined}from"@ant-design/icons";`
`4`	`4`	`import{useHistory}from"react-router-dom";`
`@@ -29,17 +29,12 @@ const EnvironmentsList: React.FC = () => {`
`29`	`29`	`const[searchText,setSearchText]=useState("");`
`30`	`30`	`const[isCreateModalVisible,setIsCreateModalVisible]=useState(false);`
`31`	`31`	`const[isCreating,setIsCreating]=useState(false);`
	`32`	`+`
	`33`	`+`
`32`	`34`
`33`	`35`	`// Hook for navigation`
`34`	`36`	`consthistory=useHistory();`
`35`	`37`
`36`		`-// Load environments on component mount`
`37`		`-useEffect(()=>{`
`38`		`-// Only fetch if environments are not already loaded`
`39`		`-if(environments.length===0&&!isLoading){`
`40`		`-dispatch(fetchEnvironments());`
`41`		`-}`
`42`		`-},[dispatch,environments.length,isLoading]);`
`43`	`38`
`44`	`39`	`// Filter environments based on search text`
`45`	`40`	`constfilteredEnvironments=environments.filter((env)=>{`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,6 @@ export const selectUnlicensedEnvironments = (state: AppState) => {`
`43`	`43`
`44`	`44`	`exportconstselectLicensedEnvironments=(state:AppState)=>{`
`45`	`45`	`constenvironments=state.ui.enterprise?.environments??[];`
`46`		`-returnenvironments.filter(env=>env.isLicensed!==false);// licensed or unknown (default to licensed)`
	`46`	`+returnenvironments.filter(env=>env.isLicensed!==false);`
`47`	`47`	`};`
`48`	`48`

Comments

(0)