Commit13dd1f6

committed

fixed embedded apps with custom comps not working

1 parent232bed3 commit13dd1f6Copy full SHA for 13dd1f6

File tree

-3

lines changed

client/packages/lowcoder/src
- appView
  - bootstrapAt.tsx
- comps/comps/customComp
  - customComp.tsx

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,6 @@ import { loadComps } from "comps";`
`2`	`2`	`importtype{AppViewInstanceOptions}from"./AppViewInstance";`
`3`	`3`	`import{createRoot}from"react-dom/client";`
`4`	`4`
`5`		`-loadComps();`
`6`		`-`
`7`	`5`	`exportasyncfunctionbootstrapAppAt<I>(`
`8`	`6`	`appId:string,`
`9`	`7`	`node:Element\|null,`
`@@ -14,6 +12,8 @@ export async function bootstrapAppAt<I>(`
`14`	`12`	`return;`
`15`	`13`	`}`
`16`	`14`
	`15`	`+loadComps();`
	`16`	`+`
`17`	`17`	`const{ AppViewInstance}=awaitimport("./AppViewInstance");`
`18`	`18`	`returnnewAppViewInstance(appId,node,createRoot(node),options);`
`19`	`19`	`}`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,8 @@ function InnerCustomComponent(props: IProps) {`
`191`	`191`	`iframe.addEventListener("load",handleIFrameLoad);`
`192`	`192`
`193`	`193`	`// in dev, load from sdk bundle and on prod load from build package`
`194`		`-constsrc=import.meta.env.DEV`
	`194`	`+constsrc=(REACT_APP_BUNDLE_TYPE&&REACT_APP_BUNDLE_TYPE==='sdk')`
	`195`	`+\|\|(import.meta.env&&import.meta.env.DEV)`
`195`	`196`	`?trans('customComponent.entryUrl')`
`196`	`197`	:`${window.location.origin}/custom_component/custom_component.html`;
`197`	`198`

Comments

(0)