Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.8k
Lottie V8, now with Nitro#1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
TheRogue76 commentedApr 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Base View is now loading fine on iOS: |
Alright, Android fixed: |
Whelp, guess i am committed now: Screen.Recording.2025-04-05.at.20.05.54.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 191 out of 203 changed files in this pull request and generated no comments.
Files not reviewed (12)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .github/FUNDING.yml: Language not supported
- .github/workflows/android-fabric-build.yml: Language not supported
- .github/workflows/android-paper-build.yml: Language not supported
- .github/workflows/ios-fabric-build.yml: Language not supported
- .github/workflows/ios-paper-build.yml: Language not supported
- .github/workflows/lint-test.yml: Language not supported
- .nvmrc: Language not supported
- .vscode/settings.json: Language not supported
- .watchmanconfig: Language not supported
- CODEOWNERS: Language not supported
Comments suppressed due to low confidence (1)
CHANGELOG.md:1
- The entire changelog has been removed. If this removal is intentional as part of the migration to the Nitro architecture, consider archiving the historical changelog to preserve critical release notes for users.
-# ChangelogThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can add our usernames.
… main thread but props are safe
iOS working now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 194 out of 206 changed files in this pull request and generated no comments.
Files not reviewed (12)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .github/FUNDING.yml: Language not supported
- .github/workflows/android-fabric-build.yml: Language not supported
- .github/workflows/android-paper-build.yml: Language not supported
- .github/workflows/ios-fabric-build.yml: Language not supported
- .github/workflows/ios-paper-build.yml: Language not supported
- .github/workflows/lint-test.yml: Language not supported
- .nvmrc: Language not supported
- .vscode/settings.json: Language not supported
- .watchmanconfig: Language not supported
- CODEOWNERS: Language not supported
Comments suppressed due to low confidence (3)
CHANGELOG.md:1
- The complete removal of the CHANGELOG.md file may lead to losing historical release information. Please confirm that the changelog has been migrated or that this deletion is intentional.
-# Changelog ... (entire file removed).yarnrc.yml:1
- Ensure that the updated Yarn configuration—including the addition of the workspace-tools plugin and the upgrade to Yarn v3.6.1—is backed by integration tests to catch any issues with dependency resolution.
nodeLinker: node-modules.github/workflows/ci.yml:71
- Review the cache key strategy to ensure that changes in dependency files are correctly detected and that cache invalidation works as intended.
key: ${{ runner.os }}-turborepo-android-${{ hashFiles('yarn.lock') }}Color filters working just fine on iOS now! |
iOS's commands are still buggy. To figure out what is exactly wrong with them. Afterwards we can do a little RC or Alpha release |
This is super exciting! 🤩 |
Have you explored usingNitro Views instead of normal Fabric views? Then you're using Nitro for everything, even callbacks. No more commands, no ObjC |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
remove stale |
Hi Marc. Sorry i have been managing a whole bunch of other projects and this message fell into my very very overflowing inbox 😅. It looks pretty much like what i would have wanted from the get go. Wouldn't mind taking another look, but don't have a lot of free time at the moment to maintain this PR or wrap it up.@matinzd Don't know if you want to take a crack at it or not, but if you do, i might be able to help |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Uh oh!
There was an error while loading.Please reload this page.
It has been entirely too painful of an experience trying to maintain this package. It is not easy to reason about, meaning that unless me or@matinzd actually put everything aside and put time on this package, usually this package is not really getting the love it deserves from other parties.
Most of this comes down to two simple things: ObjC and the structure. ObjC is nobody's cup of tea, and isn't even what Lottie iOS uses either, it is just a wrapper that lets the actual Swift API of Lottie to talk with the actual C++ API of RN. It's a stop gap mess.
Regarding the structure, a lot of it is just trying to create compliance with RN's spec for Codegen anyway. Seethis ,this,this andthis
What i want for Lottie is a simple abstraction, close to hardware, close to how RN really works, in modern languages that everyone can use. The goals are as follows:
In an ideal world, i want people to have a good API as part of RN's standard library so they can make stuff like Lottie RN on their own for their own code, and for libraries that provide basic functionality to go away, but maybe it is still too soon for that.
So we are going with Nitro. It will require some pretty high minimum RN version, but it will be worth it. We can make a V7 branch of the current Lottie, and put all the fixes in there so people can keep using the old implementation for a while longer.