NotificationsYou must be signed in to change notification settings
Fork150
Star1.8k

!default value is not assigned for some variable#44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

itismowgli wants to merge1 commit intolokesh-coder:master

base:master

Choose a base branch

fromitismowgli:master

Open

!default value is not assigned for some variable#44

itismowgli wants to merge1 commit intolokesh-coder:masterfromitismowgli:master

Conversation

Copy link

itismowgli commentedFeb 27, 2018

Your code is based on 14px base value for font-size.
It's not necessary to have the same value for others. So Based on that there should be an option to override. I've checked the code and found that there's no '!default' value assigned in the _variables.scss file.

// position$pretty-top: 8 !default;$pretty-top-switch: ($pretty-top * 2) * 1% !default;$pretty-top-offset: calc((0% - (100% - 1em)) - #{$pretty-top * 1%}) !default;$pretty-top-offset-switch: calc((0% - (100% - 1em)) - #{$pretty-top-switch}) !default;