- Notifications
You must be signed in to change notification settings - Fork24
Migrate to null safety (alternative pull request)#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit is Copyright (C) 2021 The Boston Consulting Group Pty Ltd
Closed
Owner
lokesh-coder commentedJun 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@ryanheise Thanks for your work! PR changes looks good to me. If you find time, please update the package version to 2.0.0. |
ContributorAuthor
ryanheise commentedJun 15, 2021
Just updated the version number. |
Owner
lokesh-coder commentedJun 15, 2021
@ryanheise Thank you so much for your work. v2.0.0 is merged and published 🎉. |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I originally tried#6 but ran into various null check errors, so this is an alternative pull request. All pages in the example seem to work correctly.
I have not updated the version number in this PR but as per the Dart null safety migration guide, this is considered a breaking change and therefore the version should be bumped to 2.0.0.
Fixes#5