- Notifications
You must be signed in to change notification settings - Fork7.1k
Remove _.template JSDoc examples from lodash.js to prevent false posi…#5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tive source disclosure findingsRemoved the JSDoc comment block for the _.template function from lodash.js. The documentation included usage examples such as <% print("hello " + user); %> and <%- value %>, which are detected by security scanners (e.g., Burp Suite) as potential ASP Classic or server-side template source code disclosure, resulting in persistent false positive findings during automated scans.While this is not an actual vulnerability, the comment block triggers unnecessary alerts and adds overhead to remediation workflows. The removal is limited to documentation comments only and does not affect lodash’s runtime functionality.This change reduces noise in security reports and simplifies compliance reviews without impacting the library’s intended behavior.
Gb2real left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Completely agree with the statement of fact
| * object is given, it takes precedence over `_.templateSettings` values. | ||
| * | ||
| * **Note:** In the development build `_.template` utilizes | ||
| * [sourceURLs](http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/#toc-sourceurl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Complete with all the details and information about this event
Gb2real commentedJun 30, 2025
Please merge immediately thank you |
…tive source disclosure findings
Removed the JSDoc comment block for the _.template function from lodash.js. The documentation included usage examples such as <% print("hello " + user); %> and <%- value %>, which are detected by security scanners (e.g., Burp Suite) as potential ASP Classic or server-side template source code disclosure, resulting in persistent false positive findings during automated scans.
While this is not an actual vulnerability, the comment block triggers unnecessary alerts and adds overhead to remediation workflows. The removal is limited to documentation comments only and does not affect lodash’s runtime functionality.
This change reduces noise in security reports and simplifies compliance reviews without impacting the library’s intended behavior.