- Notifications
You must be signed in to change notification settings - Fork7.1k
Refactor createMathOperation method to use convertToNumberOrString utility#5919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
saddamhr wants to merge435 commits intolodash:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Refactor createMathOperation method to use convertToNumberOrString utility#5919
saddamhr wants to merge435 commits intolodash:mainfromsaddamhr:refactor/createmathoperation-method-with-utility-converter
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ith` to other methods.
One example now shows that specifying a padding length of less than thelength of the string returns the entire original string.
Since `function flow(funcs)` changed to `function flow(...funcs)` this ternary became unnecessary, since funcs will always have a length now.
The return type should be `boolean` instead of `number`
Remove the unused param `hash` from the jsdoc of `Hash#delete`
…dash#4681)--save is a command-line option and it should be monospacedCo-authored-by: utkarsh-kukreti <utkarshk@dewsolutions.in>
The `opt-cli` pre-push functionality was removed from lodash just a few daysafter it was added (seelodash@2cd12c3),but the documentation encouraging contributors to use it still remains.Remove to avoid confusion for new contributors.
The master branch has been in flux for a pretty long time, so leavingthe broken npm scripts and messages in CONTRIBUTING.md doesn't makesense and has been confusing to contributors. This commit removes brokennpm scripts and removes all unnecessary dependencies for now.
I've commented out a test for `_.merge` and will re-look it as Igradually cleanup the codebase.
`npm cit` is short for `npm ci` and `npm test`
Signed-off-by: tison <wander4096@gmail.com>
* test: fix throttle.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix pickBy.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix isBuffer.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: partially fix attempt.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: partially fix dropRightWhile.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix defer.spec.js and rest.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix invoke.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix isArray.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: partially fix iteration-methods.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix xor-methods.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix property.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix ary.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix omit-methods.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix debounce-and-throttle.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix unzip-and-zip.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix toPairs-methods.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix exit-early.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: temporarily comment out takeWhile and dropWhile testsSigned-off-by: tison <wander4096@gmail.com>* test: partially fix union*.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix startsWith-and-endsWith.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix isNil.spec.jsSigned-off-by: tison <wander4096@gmail.com>* test: fix some of syntax errorsSigned-off-by: tison <wander4096@gmail.com>---------Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
91 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
createMathOperationmethod to improve its code structure by introducing theconvertToNumberOrStringutility function. The changes ensure that type conversion logic is abstracted into a separate helper function, improving readability and maintainability.Changes
createMathOperationwith theconvertToNumberOrStringutility.Test Plan
All existing unit tests for the
addmethod have been executed successfully to confirm that functionality remains intact.add(6, 4)returns10add('6', '4')returns'64'undefinedvalues and mixed input types.This refactor maintains backward compatibility while cleaning up the code.