Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove use of http2_server in replicator aws proxy#62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
thrau wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromremote-http2-server

Conversation

@thrau
Copy link
Member

@thrauthrau commentedJun 4, 2024
edited
Loading

Motivation

🚧

Fixes#45

This is an attempt to move away from the http2_server implementation, by replacing the current auth proxy implementation with a handler chain.

Changes

  • ...

alexrashed and whummer reacted with hooray emojiwhummer reacted with rocket emoji
@thrauthrau requested a review fromwhummer as acode ownerJune 4, 2024 20:50
@thrauthrauforce-pushed theremote-http2-server branch from8e0e63f to49b5a01CompareJune 4, 2024 21:22
@thrauthrau marked this pull request as draftJune 4, 2024 23:36
@thrauthrau marked this pull request as draftJune 4, 2024 23:36
@thrauthrau marked this pull request as ready for reviewJune 4, 2024 23:36
@thrauthrau marked this pull request as draftJune 4, 2024 23:36
@thrau
Copy link
MemberAuthor

May not have been that easy after all. Will investigate further..

@thrau
Copy link
MemberAuthor

I tried to re-write the entire proxying mechanism by re-using more from our handler chain, but there still seem to be several issues related to headers and streaming data, which I think is a result of the proxy mechanism on both sides doing too many things to the request.

I need to sit down with@whummer to better understand what the components should be doing exactly before moving forward, because I'm shotgun debugging at this point.

@whummer
Copy link
Member

Thanks for digging into this@thrau and getting the extension upgraded to the new gateway logic! 🙌 Happy to do some pairing on this - or maybe I'll find some time this weekend to dig into it a bit.. Let's compare notes soon!

@whummer
Copy link
Member

@thrau Sorry for the delay, finally got a chance to look into this. Great job on the refactoring and removing the use ofhttp2_server! 🚀 Pushed a small change to dropTransfer-Encoding headers from the proxied response, see:https://github.com/localstack/localstack-extensions/pull/62/files#diff-ee721dbb335a260769d713b880c29dc772e825e268aedea2a0b3d67fd7f99bc3R46-R47

Was running some quick tests locally, seems to be working. 🎉 At least for S3 requests - these buckets are proxied from a real AWS account:

$ awslocal s3 ls2024-06-20 22:25:33 ls-test-whummer-1232024-06-20 22:51:04 test-bucket-a8c53ada

SQS tests still seem to be failing in the CI pipeline, we can look into those next.. 👀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@whummerwhummerAwaiting requested review from whummer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove usages of deprecated LocalStack code features in AWS replicator

3 participants

@thrau@whummer

[8]ページ先頭

©2009-2025 Movatter.jp