Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix get_raw_path parsing#8962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bentsku merged 1 commit intomasterfromfix-raw-uri-parsing
Aug 22, 2023
Merged

fix get_raw_path parsing#8962

bentsku merged 1 commit intomasterfromfix-raw-uri-parsing
Aug 22, 2023

Conversation

@bentsku
Copy link
Contributor

Motivation

This PR wouldfix#8928 and#8924. We had an issue with parsing the WSGI environRAW_URI, because an HTTP request can also contain a full URL and not only an absolute path. See the RFC:https://www.ietf.org/rfc/rfc2616.txt

   To allow for transition to absoluteURIs in all requests in future   versions of HTTP, all HTTP/1.1 servers MUST accept the absoluteURI   form in requests, even though HTTP/1.1 clients will only generate   them in requests to proxies.

We would then have more than the path withget_raw_path, which lead to issue down the road when trying to match in our router.

Changes

We now thanks to@dfangl parse theRAW_URI variable withurllib.parse.urlparse to then only get thepath part of theRAW_URI in case there's more.
Added a unit test covering this use case.

@bentskubentsku added area: asf semver: patchNon-breaking changes which can be included in patch releases labelsAug 22, 2023
@bentskubentsku self-assigned thisAug 22, 2023
@bentskubentsku requested a review fromdfanglAugust 22, 2023 16:22
@bentskubentsku marked this pull request as ready for reviewAugust 22, 2023 16:24
@bentskubentsku requested a review fromthrau as acode ownerAugust 22, 2023 16:24
@bentskubentsku linked an issueAug 22, 2023 that may beclosed by this pull request
1 task
@coveralls
Copy link

Coverage Status

coverage: 80.725% (+0.07%) from 80.658% when pulling00c22b0 on fix-raw-uri-parsing intodacb3c8 on master.

Copy link
Member

@dfangldfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dfangldfangldfangl approved these changes

@thrauthrauAwaiting requested review from thrau

Assignees

@bentskubentsku

Labels

area: asfsemver: patchNon-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: LocalStack.NET all S3 operations fails on LocalStack 2.2 bug: LocalStack.NET SQS DeleteQueue fails on LocalStack 2.2

4 participants

@bentsku@coveralls@dfangl

[8]ページ先頭

©2009-2025 Movatter.jp