Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

SFN:TestState: Add validations for mock fields compatibility#13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gregfurman merged 2 commits intomainfromsfn/feat/add-mock-contents-validations
Dec 5, 2025

Conversation

@tiurin
Copy link
Contributor

@tiurintiurin commentedDec 4, 2025•
edited
Loading

Motivation

Improve test state mock validation parity.

Closes DRG-311.

Changes

  • Updates the validation message to match the AWS one when both mock result and error are present. Also, moves the validation to the static analyzer to group it with the rest of mock validations.
  • Adds validation for revealSecrets cannot be true when a mock is specified

Tests

Related

Also moves the validation to the static analyzer to group it with the rest of mock validations.
@tiurintiurin added aws:stepfunctionsAWS Step Functions semver: patchNon-breaking changes which can be included in patch releases docs: skipPull request does not require documentation changes notes: skipPull request does not have to be mentioned in the release notes labelsDec 4, 2025
@github-actions
Copy link

github-actionsbot commentedDec 4, 2025•
edited
Loading

Test Results - Preflight, Unit

22 889 tests  ±0   21 075 ✅ ±0   6m 21s ⏱️ -11s
     1 suites ±0    1 814 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit5abe957. ± Comparison against base commit53d7108.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actionsbot commentedDec 4, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 50s ⏱️ -9s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit5abe957. ± Comparison against base commit53d7108.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actionsbot commentedDec 4, 2025•
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   21m 30s ⏱️ - 1h 35m 3s
1 714 tests  - 3 407  1 625 ✅  - 3 104  89 💤  - 303  0 ❌ ±0 
1 716 runs   - 3 407  1 625 ✅  - 3 104  91 💤  - 303  0 ❌ ±0 

Results for commit5abe957. ± Comparison against base commit53d7108.

This pull requestremoves 3409 andadds 2 tests.Note that renamed tests count towards both.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…
tests.aws.services.stepfunctions.v2.test_state.test_state_mock_validation.TestStateMockValidation ‑ test_both_mock_result_and_mock_error_output_are_settests.aws.services.stepfunctions.v2.test_state.test_state_mock_validation.TestStateMockValidation ‑ test_reveal_secrets_is_true_and_mock_result_is_set

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actionsbot commentedDec 4, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   39m 5s ⏱️
1 738 tests 1 650 ✅ 88 💤 0 ❌
1 744 runs  1 650 ✅ 94 💤 0 ❌

Results for commit5abe957.

♻️ This comment has been updated with latest results.

@tiurintiurin changed the titleSFN: Fix validation message for when both mock result and error are presentSFN:TestState: Add validations for mock contentsDec 4, 2025
@tiurintiurin changed the titleSFN:TestState: Add validations for mock contentsSFN:TestState: Add validations for mock fields compatibilityDec 4, 2025
@tiurintiurin added the review: merge when readySignals to the reviewer that a PR can be merged if accepted labelDec 5, 2025
Copy link
Contributor

@gregfurmangregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Just a small concern aboutNone being passed in if definition is not provided.

@gregfurmangregfurman merged commit310f7d8 intomainDec 5, 2025
51 checks passed
@gregfurmangregfurman deleted the sfn/feat/add-mock-contents-validations branchDecember 5, 2025 09:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gregfurmangregfurmangregfurman approved these changes

Assignees

No one assigned

Labels

aws:stepfunctionsAWS Step Functionsdocs: skipPull request does not require documentation changesnotes: skipPull request does not have to be mentioned in the release notesreview: merge when readySignals to the reviewer that a PR can be merged if acceptedsemver: patchNon-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiurin@gregfurman
[8]ページ先頭
©2009-2025 Movatter.jp