Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SFN][TestState] Add test for invalid state machine definition in test state call#13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiurin merged 1 commit intomainfromsfn/feat/test-state-state-name-validation
Dec 4, 2025

Conversation

@tiurin
Copy link
Contributor

Ignoring the exact validation message for now

Motivation

Add tests for failure modes.

Closes DRG-133.

Changes

Adds a test for invalid state machine definition in test state call.

ANTLR parser message has different wording but the same meaning as AWS response. Not investing time now to convert to the exact same wording - relying on error code for test.

Tests

Related

@tiurintiurin added semver: patchNon-breaking changes which can be included in patch releases docs: skipPull request does not require documentation changes notes: skipPull request does not have to be mentioned in the release notes aws:stepfunctionsAWS Step Functions labelsDec 1, 2025
@github-actions
Copy link

github-actionsbot commentedDec 1, 2025•
edited
Loading

Test Results - Preflight, Unit

22 889 tests  ±0   21 075 ✅ ±0   6m 31s ⏱️ +5s
     1 suites ±0    1 814 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commitfd25c20. ± Comparison against base commitcb8043c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actionsbot commentedDec 1, 2025•
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   22m 8s ⏱️ - 1h 33m 13s
1 712 tests  - 3 400  1 623 ✅  - 3 097  89 💤  - 303  0 ❌ ±0 
1 714 runs   - 3 400  1 623 ✅  - 3 097  91 💤  - 303  0 ❌ ±0 

Results for commitfd25c20. ± Comparison against base commitcb8043c.

This pull requestremoves 3401 andadds 1 tests.Note that renamed tests count towards both.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…
tests.aws.services.stepfunctions.v2.test_state.test_test_state_machine_scenarios.TestStateMachineScenarios ‑ test_state_name_invalid_state_definition

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actionsbot commentedDec 1, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commitfd25c20. ± Comparison against base commitcb8043c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actionsbot commentedDec 1, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   38m 58s ⏱️
1 736 tests 1 648 ✅ 88 💤 0 ❌
1 742 runs  1 648 ✅ 94 💤 0 ❌

Results for commitfd25c20.

♻️ This comment has been updated with latest results.

Ignoring the exact validation message for now
@tiurintiurinforce-pushed thesfn/feat/test-state-state-name-validation branch from3004b16 tofd25c20CompareDecember 4, 2025 12:18
@tiurintiurin merged commitb8e33ce intomainDec 4, 2025
42 checks passed
@tiurintiurin deleted the sfn/feat/test-state-state-name-validation branchDecember 4, 2025 13:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gregfurmangregfurmangregfurman approved these changes

Assignees

No one assigned

Labels

aws:stepfunctionsAWS Step Functionsdocs: skipPull request does not require documentation changesnotes: skipPull request does not have to be mentioned in the release notessemver: patchNon-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiurin@gregfurman
[8]ページ先頭
©2009-2025 Movatter.jp