Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix/ssm put parameter operation#13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jasjaapdua wants to merge2 commits intolocalstack:main
base:main
Choose a base branch
Loading
fromjasjaapdua:fix/ssm-put-parameter-operation

Conversation

@jasjaapdua
Copy link

@jasjaapduajasjaapdua commentedNov 29, 2025
edited
Loading

Motivation

SSMput_parameter events currently always emitoperation: "Create", even when overwriting an existing parameter. AWS emitsoperation: "Update" on overwrite, so downstream listeners see incorrect event detail in LocalStack.

Changes

  • Set the SSM event operation to"Update" whenput_parameter returns a version > 1, otherwise"Create".
  • Added a unit test to assert Create→Update emission when overwriting.

Tests

  • python -m pytest tests/unit/test_ssm_put_parameter_events.py
  • make lint
  • make format

Related

@localstack-bot
Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commentingrecheck in this Pull Request.Posted by theCLA Assistant Lite bot.

Copy link
Contributor

@localstack-botlocalstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining ourSlack Community and share your PR on the#community channel to share your contributions with us. Please make sure you are following ourcontributing guidelines and ourCode of Conduct.

@jasjaapdua
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jasjaapdua
Copy link
Author

The CI checks have failed because of missing labels and I don't have the permission to edit the labels now.

Could a maintainer please add the following labels?

  • docs:skip
  • notes:skip
  • semver:patch

This PR is a small bugfix that aligns the SSMPutParameter event behaviour with that of AWS. Thanks!

@viren-nadkarniviren-nadkarni added semver: patchNon-breaking changes which can be included in patch releases docs: skipPull request does not require documentation changes notes: skipPull request does not have to be mentioned in the release notes labelsDec 3, 2025
Copy link
Member

@viren-nadkarniviren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for raising the PR!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you write a AWS-validated integration test instead of this unit test? You can read more about themhere.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@localstack-botlocalstack-botlocalstack-bot left review comments

@viren-nadkarniviren-nadkarniviren-nadkarni requested changes

@dominikschubertdominikschubertAwaiting requested review from dominikschubertdominikschubert is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

docs: skipPull request does not require documentation changesnotes: skipPull request does not have to be mentioned in the release notessemver: patchNon-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ssm parameter update should send "Update" event, but sends "Create" event

3 participants

@jasjaapdua@localstack-bot@viren-nadkarni

[8]ページ先頭

©2009-2025 Movatter.jp