NotificationsYou must be signed in to change notification settings
Fork4.5k
Star63.7k

S3: fix change in behavior in CreateBucketConfiguration#13427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bentsku merged 1 commit intomainfromfix-s3-create-bucket

Nov 27, 2025

Merged

S3: fix change in behavior in CreateBucketConfiguration#13427

bentsku merged 1 commit intomainfromfix-s3-create-bucket

Nov 27, 2025

Conversation

Copy link

Contributor

bentsku commentedNov 27, 2025•
edited
Loading

Motivation

We got a report that the newer 6.23 Terraform AWS provider version is failing with LocalStack:#13426

This is due to a change in what exceptions are being raised by AWS: previously, if the body contained aCreateBucketConfiguration XML tag, it also needed to have theLocationConstraint tag inside of it. This seems to have change in AWS, probably related to the new addition of theTags XML tag inside of it: seehttps://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html#AmazonS3-CreateBucket-request-Tags

When trying to revalidate the test against AWS, the exception was not raised anymore, so the logic of the provider has been updated.

There is still more to be done to make the6.23 AWS provider work with LocalStack, because it requires the new tagging endpoints that are not yet part of our stubs. Some follow-up work will still need to be done.

Changes

do not validate thatCreateBucketConfiguration must containLocationConstraint anymore
update the tests against AWS

Next up

Support theTags input value inCreateBucketConfiguration

fix change in behavior in CreateBucketConfiguration

e0f53fc

bentsku added this to the4.12 milestone

Nov 27, 2025

bentsku self-assigned this

Nov 27, 2025

bentsku added aws:s3

Amazon Simple Storage Service

semver: patch

Non-breaking changes which can be included in patch releases

docs: skip

Pull request does not require documentation changes

notes: skipPull request does not have to be mentioned in the release notes labels

Nov 27, 2025

Copy link

github-actionsbot commentedNov 27, 2025

S3 Image Test Results (AMD64 / ARM64)

2 files 2 suites 8m 10s ⏱️
539 tests 487 ✅ 52 💤 0 ❌
1 078 runs 974 ✅ 104 💤 0 ❌

Results for commite0f53fc.

Copy link

github-actionsbot commentedNov 27, 2025

Test Results - Preflight, Unit

22 669 tests ±0 20 901 ✅ ±0 6m 16s ⏱️ -3s
1 suites ±0 1 768 💤 ±0
1 files ±0 0 ❌ ±0

Results for commite0f53fc. ± Comparison against base commit12934db.

Copy link

github-actionsbot commentedNov 27, 2025

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 17s ⏱️ +3s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commite0f53fc. ± Comparison against base commit12934db.

Copy link

github-actionsbot commentedNov 27, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

5 files ± 0 5 suites ±0 1h 42m 22s ⏱️ - 59m 11s
2 043 tests - 3 306 1 877 ✅ - 2 934 166 💤 - 372 0 ❌ ±0
2 049 runs - 3 306 1 877 ✅ - 2 934 172 💤 - 372 0 ❌ ±0

Results for commite0f53fc. ± Comparison against base commit12934db.

This pull requestremoves 3306 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…

♻️ This comment has been updated with latest results.

Copy link

github-actionsbot commentedNov 27, 2025

LocalStack Community integration with Pro

2 files ± 0 2 suites ±0 1h 20m 20s ⏱️ - 43m 31s
2 019 tests - 2 956 1 849 ✅ - 2 748 170 💤 - 208 0 ❌ ±0
2 021 runs - 2 956 1 849 ✅ - 2 748 172 💤 - 208 0 ❌ ±0

Results for commite0f53fc. ± Comparison against base commit12934db.

This pull requestremoves 2956 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…