Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CFNv2: minor parity assessment and triaging#12871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
simonrw wants to merge15 commits intomain
base:main
Choose a base branch
Loading
fromcfn/v2/parity-assessment

Conversation

simonrw
Copy link
Contributor

@simonrwsimonrw commentedJul 17, 2025•
edited
Loading

Motivation

While triaging the outstanding work for the CFn v2 provider project, I have made some minor changes (typically minor fixes) to gain us more parity with the v1 provider.

Changes

  • Recursively fetch nested property values (mostly for nested stacks)
  • Introduce a second "StackNotFound" type error with a different message for specific locations
  • Validate the stack name is provided indescribe_stack_events
  • Don't assume a previous update model is present, for the case of callingupdate_stack aftercreate_stack (or anotherupdate_stack)
  • Update tests that have been updated in the v1 directory
  • Unskip N tests and rescope M tests

@simonrwsimonrw added the semver: minorNon-breaking changes which can be included in minor releases, but not in patch releases labelJul 17, 2025
@localstack-bot
Copy link
Contributor

Currently, only patch changes are allowed on main. Your PR labels (semver: minor) indicate that it cannot be merged into the main at this time.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 17, 2025•
edited
Loading

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 39s ⏱️ +21s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit271f8ce. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 17, 2025•
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 3m 35s ⏱️ - 42m 58s
2 149 tests  - 2 780  1 530 ✅  - 2 622  619 💤  - 158  0 ❌ ±0 
2 151 runs   - 2 780  1 530 ✅  - 2 622  621 💤  - 158  0 ❌ ±0 

Results for commit271f8ce. ± Comparison against base commit04aa2bc.

This pull requestremoves 2780 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 17, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 6s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit271f8ce. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 17, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 24m 8s ⏱️
2 173 tests 1 557 ✅ 616 💤 0 ❌
2 179 runs  1 557 ✅ 622 💤 0 ❌

Results for commit271f8ce.

♻️ This comment has been updated with latest results.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dominikschubertdominikschubertAwaiting requested review from dominikschubertdominikschubert will be requested when the pull request is marked ready for reviewdominikschubert is a code owner

@pinzonpinzonAwaiting requested review from pinzonpinzon will be requested when the pull request is marked ready for reviewpinzon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver: minorNon-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@simonrw@localstack-bot
[8]ページ先頭
©2009-2025 Movatter.jp